* [net-next:master 731/763] drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c:852:6: sparse: symbol 'hns3_get_channels' was not declared. Should it be static?
@ 2017-12-28 1:09 kbuild test robot
2017-12-28 1:09 ` [RFC PATCH net-next] net: hns3: hns3_get_channels() can be static kbuild test robot
0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2017-12-28 1:09 UTC (permalink / raw)
To: Peng Li
Cc: kbuild-all, netdev, Mingguang Qu, Yisen Zhuang, Salil Mehta,
linux-kernel
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master
head: 55b07a65e15bea6e253a907dacaf89b61fe504ca
commit: 482d2e9c1cc7c0e154464e3e052db09e5e62541f [731/763] net: hns3: add support to query tqps number
reproduce:
# apt-get install sparse
git checkout 482d2e9c1cc7c0e154464e3e052db09e5e62541f
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__
sparse warnings: (new ones prefixed by >>)
Please review and possibly fold the followup patch.
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
^ permalink raw reply [flat|nested] 3+ messages in thread* [RFC PATCH net-next] net: hns3: hns3_get_channels() can be static
2017-12-28 1:09 [net-next:master 731/763] drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c:852:6: sparse: symbol 'hns3_get_channels' was not declared. Should it be static? kbuild test robot
@ 2017-12-28 1:09 ` kbuild test robot
2017-12-28 1:42 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2017-12-28 1:09 UTC (permalink / raw)
To: Peng Li
Cc: kbuild-all, netdev, Mingguang Qu, Yisen Zhuang, Salil Mehta,
linux-kernel
Fixes: 482d2e9c1cc7 ("net: hns3: add support to query tqps number")
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
hns3_ethtool.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c b/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c
index 2ae4d397..379c01d 100644
--- a/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c
@@ -876,8 +876,8 @@ static int hns3_nway_reset(struct net_device *netdev)
return genphy_restart_aneg(phy);
}
-void hns3_get_channels(struct net_device *netdev,
- struct ethtool_channels *ch)
+static void hns3_get_channels(struct net_device *netdev,
+ struct ethtool_channels *ch)
{
struct hnae3_handle *h = hns3_get_handle(netdev);
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-12-28 1:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-28 1:09 [net-next:master 731/763] drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c:852:6: sparse: symbol 'hns3_get_channels' was not declared. Should it be static? kbuild test robot
2017-12-28 1:09 ` [RFC PATCH net-next] net: hns3: hns3_get_channels() can be static kbuild test robot
2017-12-28 1:42 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).