From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Herbert Subject: [PATCH RFC 2/2] strparser: Call sock_owned_by_user_nocheck Date: Wed, 27 Dec 2017 17:16:35 -0800 Message-ID: <20171228011635.23562-3-tom@quantonium.net> References: <20171228011635.23562-1-tom@quantonium.net> Cc: netdev@vger.kernel.org, dvyukov@google.com, ozgur@goosey.org, Tom Herbert To: davem@davemloft.net Return-path: Received: from mail-pl0-f67.google.com ([209.85.160.67]:45217 "EHLO mail-pl0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752801AbdL1BRJ (ORCPT ); Wed, 27 Dec 2017 20:17:09 -0500 Received: by mail-pl0-f67.google.com with SMTP id o2so20282555plk.12 for ; Wed, 27 Dec 2017 17:17:09 -0800 (PST) In-Reply-To: <20171228011635.23562-1-tom@quantonium.net> Sender: netdev-owner@vger.kernel.org List-ID: strparser wants to check socket ownership without producing any warnings. As indicated by the comment in the code, it is permissible for owned_by_user to return true. Fixes: 43a0c6751a322847 ("strparser: Stream parser for messages") Reported-by: syzbot Signed-off-by: Tom Herbert --- net/strparser/strparser.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/strparser/strparser.c b/net/strparser/strparser.c index c5fda15ba319..1fdab5c4eda8 100644 --- a/net/strparser/strparser.c +++ b/net/strparser/strparser.c @@ -401,7 +401,7 @@ void strp_data_ready(struct strparser *strp) * allows a thread in BH context to safely check if the process * lock is held. In this case, if the lock is held, queue work. */ - if (sock_owned_by_user(strp->sk)) { + if (sock_owned_by_user_nocheck(strp->sk)) { queue_work(strp_wq, &strp->work); return; } -- 2.11.0