From: Stephen Hemminger <stephen@networkplumber.org>
To: Serhey Popovych <serhe.popovych@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH iproute2 2/3] utils: ll_map: Update name and type for existing entry
Date: Thu, 28 Dec 2017 09:46:45 -0800 [thread overview]
Message-ID: <20171228094645.19549fcc@xeon-e3> (raw)
In-Reply-To: <1513755451-9800-3-git-send-email-serhe.popovych@gmail.com>
On Wed, 20 Dec 2017 09:37:30 +0200
Serhey Popovych <serhe.popovych@gmail.com> wrote:
> In case of we update existing entry we need not only rehash
> but also update name in existing entry.
>
> Need to update device type too since cached interface might
> be deleted and new with same index, but different type
> added (e.g. eth0 and ppp0).
>
> Reuse new entry initialization path to avoid duplications.
>
> Signed-off-by: Serhey Popovych <serhe.popovych@gmail.com>
Can you provide an example where this is an observed bug?
I suspect that unless you use a batch mode command the reload
of the cache on next invocation is solving this.
next prev parent reply other threads:[~2017-12-28 18:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-20 7:37 [PATCH iproute2 0/3] Forbid "type" for peer, update ifname and make it array in ll_cache Serhey Popovych
2017-12-20 7:37 ` [PATCH iproute2 1/3] vxcan,veth: Forbid "type" for peer device Serhey Popovych
2017-12-26 17:05 ` Stephen Hemminger
2017-12-28 10:54 ` Serhey Popovych
2017-12-28 11:01 ` Serhey Popovych
2017-12-28 17:40 ` Stephen Hemminger
2017-12-20 7:37 ` [PATCH iproute2 2/3] utils: ll_map: Update name and type for existing entry Serhey Popovych
2017-12-28 17:46 ` Stephen Hemminger [this message]
2017-12-28 18:22 ` Serhey Popovych
2017-12-20 7:37 ` [PATCH iproute2 3/3] utils: ll_map: Make network device name fixed size array of char Serhey Popovych
2017-12-28 17:45 ` Stephen Hemminger
2017-12-28 18:17 ` Serhey Popovych
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171228094645.19549fcc@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=netdev@vger.kernel.org \
--cc=serhe.popovych@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).