From mboxrd@z Thu Jan 1 00:00:00 1970 From: Antoine Tenart Subject: Re: [PATCH net-next 5/6] arm64: dts: marvell: mcbin: enable the fourth network interface Date: Thu, 28 Dec 2017 11:05:19 +0100 Message-ID: <20171228100519.GE2626@kwain> References: <20171227221446.18459-1-antoine.tenart@free-electrons.com> <20171227221446.18459-6-antoine.tenart@free-electrons.com> <20171227222401.GT10595@n2100.armlinux.org.uk> <20171228074623.GA28444@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Cc: Russell King - ARM Linux , Antoine Tenart , davem@davemloft.net, kishon@ti.com, jason@lakedaemon.net, sebastian.hesselbarth@gmail.com, gregory.clement@free-electrons.com, mw@semihalf.com, stefanc@marvell.com, ymarkman@marvell.com, thomas.petazzoni@free-electrons.com, miquel.raynal@free-electrons.com, nadavh@marvell.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org To: Andrew Lunn Return-path: Received: from mail.free-electrons.com ([62.4.15.54]:45467 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753032AbdL1KFj (ORCPT ); Thu, 28 Dec 2017 05:05:39 -0500 Content-Disposition: inline In-Reply-To: <20171228074623.GA28444@lunn.ch> Sender: netdev-owner@vger.kernel.org List-ID: Hi Andrew, On Thu, Dec 28, 2017 at 08:46:23AM +0100, Andrew Lunn wrote: > On Wed, Dec 27, 2017 at 10:24:01PM +0000, Russell King - ARM Linux wrote: > > On Wed, Dec 27, 2017 at 11:14:45PM +0100, Antoine Tenart wrote: > > > > > > +&cps_eth2 { > > > + /* CPS Lane 5 */ > > > + status = "okay"; > > > + phy-mode = "2500base-x"; > > > + /* Generic PHY, providing serdes lanes */ > > > + phys = <&cps_comphy5 2>; > > > +}; > > > + > > > > This is wrong. This lane is connected to a SFP cage which can support > > more than just 2500base-X. Tying it in this way to 2500base-X means > > that this port does not support conenctions at 1000base-X, despite > > that's one of the most popular and more standardised speeds. > > > > I agree with Russell here. SFP modules are hot pluggable, and support > a range of interface modes. You need to query what the SFP module is > in order to know how to configure the SERDES interface. The phylink > infrastructure does that for you. Sure, I understand. We'll be able to support such interfaces only when the phylink PPv2 support lands in. Thanks! Antoine -- Antoine Ténart, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com