From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jiri Pirko <jiri@resnulli.us>
Subject: Re: [patch net-next v2 00/10] Add support for resource abstraction
Date: Thu, 28 Dec 2017 17:43:58 +0100
Message-ID: <20171228164358.GB1983@nanopsycho>
References: <20171226112359.5313-1-jiri@resnulli.us>
 <c72fd96e-9f46-974c-733f-3c9336285d52@cumulusnetworks.com>
 <20171227080902.GA1997@nanopsycho>
 <ae70d810-8277-899b-b2a9-6b2dbdd5eb21@cumulusnetworks.com>
 <VI1PR05MB35206F8E7CB725188F9F509EBF040@VI1PR05MB3520.eurprd05.prod.outlook.com>
 <22cc777b-e39e-29c0-22fe-aa7a99ef80df@cumulusnetworks.com>
 <20171228162314.GA1983@nanopsycho>
 <4bd0a9d4-350d-274c-6370-e3a98a1e4f93@cumulusnetworks.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Yuval Mintz <yuvalm@mellanox.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "davem@davemloft.net" <davem@davemloft.net>,
        Arkadi Sharshevsky <arkadis@mellanox.com>,
        mlxsw <mlxsw@mellanox.com>, "andrew@lunn.ch" <andrew@lunn.ch>,
        "vivien.didelot@savoirfairelinux.com"
        <vivien.didelot@savoirfairelinux.com>,
        "f.fainelli@gmail.com" <f.fainelli@gmail.com>,
        "michael.chan@broadcom.com" <michael.chan@broadcom.com>,
        "ganeshgr@chelsio.com" <ganeshgr@chelsio.com>,
        Saeed Mahameed <saeedm@mellanox.com>,
        Matan Barak <matanb@mellanox.com>,
        Leon Romanovsky <leonro@mellanox.com>,
        Ido Schimmel <idosch@mellanox.com>,
        "jakub.kicinski@netronome.com" <jakub.kicinski@netronome.com>,
        "ast@kernel.org" <ast@kernel.org>,
        "daniel@iogearbox.net" <daniel@iogearbox.net>,
        "
To: David Ahern <dsa@cumulusnetworks.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-wr0-f182.google.com ([209.85.128.182]:34615 "EHLO
        mail-wr0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750765AbdL1QoA (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 28 Dec 2017 11:44:00 -0500
Received: by mail-wr0-f182.google.com with SMTP id 36so6376632wrh.1
        for <netdev@vger.kernel.org>; Thu, 28 Dec 2017 08:44:00 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <4bd0a9d4-350d-274c-6370-e3a98a1e4f93@cumulusnetworks.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

Thu, Dec 28, 2017 at 05:33:58PM CET, dsa@cumulusnetworks.com wrote:
>On 12/28/17 10:23 AM, Jiri Pirko wrote:
>>> So there are 4 tables exported to userspace:
>>>
>>> 1. mlxsw_erif table which is not in any of the kvd regions (no resource
>>> path is given) and it has a size of 1000. Does mlxsw_erif mean a rif as
>>> in Router Interfaces? So the switch supports up to 1000 router interfaces.
>>>
>>> 2. mlxsw_host4 in /kvd/hash_single with a size of 62. Based on the
>> Size tells you the actual size. It cannot give you max size. The reason
>> is simple. The resources are shared among multiple tables. That is
>> exactly what this resource patch makes visible.
>> 
>> 
>
>In the erif table, the 1000 is the max not current usage. I do not have

I believe that is a bug in erif dpipe implementation
(mlxsw_sp_dpipe_table_erif_size_get) We'll fix that. Thanks!



>1000 interfaces:
>
>$ ip -br li sh | wc -l
>597
>
>
>$ devlink dpipe table dump pci/0000:03:00.0 name mlxsw_erif
>...
>  index 503
>  match_value:
>    type field_exact header mlxsw_meta field erif_port mapping ifindex
>mapping_value 601 value 503
>  action_value:
>    type field_modify header mlxsw_meta field l3_forward value 1
>
>
>The host4 table it is current size with no maximum.
>
>The meaning of table size needs to be consistent across tables.