From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jakub Kicinski <kubakici@wp.pl>
Subject: Re: [PATCH net 3/3] eet: ena: invoke netif_carrier_off() only after
 netdev registered
Date: Fri, 29 Dec 2017 00:09:43 -0800
Message-ID: <20171229000943.218cb691@cakuba.netronome.com>
References: <1514496620-69953-1-git-send-email-netanel@amazon.com>
        <1514496620-69953-4-git-send-email-netanel@amazon.com>
        <20171228234603.436ba946@cakuba.netronome.com>
        <B0951795-C990-49ED-9972-CDEED0F160A6@amazon.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: "davem@davemloft.net" <davem@davemloft.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "Woodhouse, David" <dwmw@amazon.co.uk>,
        "Machulsky, Zorik" <zorik@amazon.com>,
        "Matushevsky, Alexander" <matua@amazon.com>,
        "Bshara, Saeed" <saeedb@amazon.com>,
        "Wilson, Matt" <msw@amazon.com>,
        "Liguori, Anthony" <aliguori@amazon.com>,
        "Bshara, Nafea" <nafea@amazon.com>,
        "Schmeilin, Evgeny" <evgenys@amazon.com>,
        "Tzalik, Guy" <gtzalik@amazon.com>
To: "Belgazal, Netanel" <netanel@amazon.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mx4.wp.pl ([212.77.101.11]:7175 "EHLO mx4.wp.pl"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1755107AbdL2IJw (ORCPT <rfc822;netdev@vger.kernel.org>);
        Fri, 29 Dec 2017 03:09:52 -0500
In-Reply-To: <B0951795-C990-49ED-9972-CDEED0F160A6@amazon.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Fri, 29 Dec 2017 08:00:33 +0000, Belgazal, Netanel wrote:
> Yes, I mean in my driver.
> netif_carrier_off() have no effect when netdev is uninitialized.

Please look at the implementation again, test_*and_set*_bit().

> So I must call it after register_netdev().

Is there a user-visible problem you're trying to solve here?