From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
David <davem@davemloft.net>, Guenter Roeck <linux@roeck-us.net>,
Cory Tusar <cory.tusar@pid1solutions.com>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH 3/3] net: dsa: Allow configuration of CPU & DSA port speeds/duplex
Date: Fri, 19 Jun 2015 11:48:28 -0400 (EDT) [thread overview]
Message-ID: <2017950579.56305.1434728908030.JavaMail.zimbra@savoirfairelinux.com> (raw)
In-Reply-To: <20150619150533.GH3557@lunn.ch>
Hi Andrew,
On Jun 19, 2015, at 11:05 AM, Andrew Lunn andrew@lunn.ch wrote:
>> Yes I do have debug too, but via sysfs (with eventually write access) for:
>> GLOBAL1, GLOBAL2, cpu port registers, SerDes registers, PVIDs, and VTU.
>> Not really standard though.
>
> We should really get an implementation into mainline. There is no
> point us all implementing our own.
I couldn't agree more. It's important for development to have read/write
access to the switch registers, bypassing the userspace tools.
> You say your code is not really standard. Do you think it would get
> rejected if it was submitted? The rules for debugfs are much more
> relaxed, so what i have should be acceptable.
Yes my code will definitely be rejected. I have a net/dsa/debug.c file
that creates a debug directory under /sys/devices/platform/dsa.0/ with
global1, global2, cpu_port, serdes, pvid, and vtu sysfs attributes.
Read and write access to debugfs sounds better IMO.
Thanks,
-v
prev parent reply other threads:[~2015-06-19 15:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-12 17:18 [PATCH 1/3] net: phy: Allow PHY devices to identify themselves as Ethernet switches, etc Andrew Lunn
2015-06-12 17:18 ` [PATCH 2/3] dsa: mv88e6xxx: Allow speed/duplex of port to be configured Andrew Lunn
2015-06-12 17:18 ` [PATCH 3/3] net: dsa: Allow configuration of CPU & DSA port speeds/duplex Andrew Lunn
2015-06-12 18:03 ` Guenter Roeck
2015-06-12 18:14 ` Florian Fainelli
2015-06-12 18:29 ` Guenter Roeck
2015-06-15 17:32 ` Florian Fainelli
2015-06-12 18:38 ` Andrew Lunn
2015-06-15 17:35 ` Florian Fainelli
2015-06-17 18:09 ` Vivien Didelot
2015-06-18 1:11 ` Andrew Lunn
2015-06-19 15:05 ` Vivien Didelot
2015-06-19 15:05 ` Andrew Lunn
2015-06-19 15:48 ` Vivien Didelot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2017950579.56305.1434728908030.JavaMail.zimbra@savoirfairelinux.com \
--to=vivien.didelot@savoirfairelinux.com \
--cc=andrew@lunn.ch \
--cc=cory.tusar@pid1solutions.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=linux@roeck-us.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).