From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Poirier Subject: Re: [PATCH for-4.14.y 0/5] e1000e: Upstream fixes for linux-4.14.y Date: Mon, 1 Jan 2018 12:53:09 +0900 Message-ID: <20180101035309.mccohvczwpuop66o@f1.synalogic.ca> References: <1511787217-10987-1-git-send-email-amit.pundir@linaro.org> <20171204164700.0600b925@leda> <20171204183722.GB13501@kroah.com> <20171205082327.629d5e78@leda> <20171205073545.GA15358@kroah.com> <20171211225810.2ed2b86b@leda> <20171218115949.GC10163@kroah.com> <20171219011012.ilvmd74fqplzhren@f1.synalogic.ca> <1513726051.27260.1.camel@intel.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ukndg6ovr6n4rtgo" Cc: Greg KH , Christian Hesse , Amit Pundir , Sasha Neftin , Stable , netdev@vger.kernel.org, Stephane Coin , Pavel Semerad , Ben Hutchings To: Jeff Kirsher Return-path: Content-Disposition: inline In-Reply-To: <1513726051.27260.1.camel@intel.com> Sender: stable-owner@vger.kernel.org List-Id: netdev.vger.kernel.org --ukndg6ovr6n4rtgo Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2017/12/19 15:27, Jeff Kirsher wrote: > On Tue, 2017-12-19 at 10:10 +0900, Benjamin Poirier wrote: > > On 2017/12/18 12:59, Greg KH wrote: > > > On Mon, Dec 11, 2017 at 10:58:10PM +0100, Christian Hesse wrote: > > > > Greg KH on Tue, 2017/12/05 08:35: > > > > > On Tue, Dec 05, 2017 at 08:23:27AM +0100, Christian Hesse wrote: > > > > > > Greg KH on Mon, 2017/12/04 19:37: = =20 > > > > > > > On Mon, Dec 04, 2017 at 04:47:00PM +0100, Christian Hesse > > > > > > > wrote: =20 > > > > > > > > Amit Pundir on Mon, 2017/11/27 > > > > > > > > 18:23: =20 > > > > > > > > > Hi Greg, > > > > > > > > >=20 > > > > > > > > > Found few e100e upstream fixes from Benjamin Poirier in > > > > > > > > > lede > > > > > > > > > source tree, https://git.lede-project.org/?p=3Dsource.git, > > > > > > > > > and > > > > > > > > > these fixes seem reasonable enough for 4.14.y too. > > > > > > > > >=20 > > > > > > > > > Also submitting an e1000e buffer overrun fix by Sasha > > > > > > > > > Neftin. > > > > > > > > >=20 > > > > > > > > > Cherry-picked and build tested for linux v4.14.2 for > > > > > > > > > ARCH=3Darm/arm64. > > > > > > > > >=20 > > > > > > > > > Regards, > > > > > > > > > Amit Pundir > > > > > > > > >=20 > > > > > > > > >=20 > > > > > > > > > Benjamin Poirier (4): > > > > > > > > > e1000e: Fix error path in link detection > > > > > > > > > e1000e: Fix return value test > > > > > > > > > e1000e: Separate signaling for link check/link up > > > > > > > > > e1000e: Avoid receiver overrun interrupt bursts > > > > > > > > >=20 > > > > > > > > > Sasha Neftin (1): > > > > > > > > > e1000e: fix buffer overrun while the I219 is processing > > > > > > > > > DMA > > > > > > > > > transactions =20 > > > > > > > >=20 > > > > > > > > Hello everybody, > > > > > > > >=20 > > > > > > > > looks like one of these breaks connectivity on my Thinkpad > > > > > > > > X250. > > > > > > > > Just downgraded to linux 4.14.2 to verify. =20 > > > > > > >=20 > > > > > > > Can you try the -rc release I just did? It has a fix for this > > > > > > > series in > > > > > > > it. =20 > > > > > >=20 > > > > > > It connects with the notebook's built in ethernet port (did not > > > > > > check with > > > > > > 4.14.3) but still fails to see a link when placed in docking > > > > > > station. =20 > > > > >=20 > > > > > Do you have the same issues with 4.15-rc2? > > > >=20 > > > > Just a short heads-up and final result for this thread... > > > > The issue is fixed with Benjamin's patch: > > > >=20 > > > > https://patchwork.kernel.org/patch/10104349/ > > >=20 > > > Any word on getting this patch into Linus's tree anytime soon? > >=20 > > Apparently the intel maintainer was unavailable recently: > > https://www.mail-archive.com/netdev@vger.kernel.org/msg206192.html > >=20 > > The patch is now in there: > > https://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/next-queue.git= /l > > og/?h=3Ddev-queue > > but that only makes it slated for 4.16 AFAIK. > >=20 > > Jeff, given that this issue breaks networking for many people, wouldn't > > it be more appropriate to submit the patch for 4.15? >=20 > Yeah, I will send to Dave's net tree (4.15) for inclusion. Jeff, I see that the patch is still in your "next-queue". Meanwhile another 4.15 rc has been released and I've gotten more user reports that e1000e is broken. --ukndg6ovr6n4rtgo Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEkvpDtefvZykbqQVOaJBbS33YWS0FAlpJsKAACgkQaJBbS33Y WS34xQ/9HN0qgh4Uuvn4TQCsfksNb29R6K12UdHsKm1LZxdLFfmUx3tBG1NH5niL kOZF3lTBk75WfBczS74QF0ME7bggBtqPCNo65xYSprXUEe8WFCaUdAareS/LdZDG 5EZXsKKPfgQJLonjgrnRFPt15AX0MvQH4TNtQjjokkkgVnvjeJ4m7Xx1W0fBCOWh N/qdEfufH6kHxtdF0UrJvjSbQRcaUc5Vn2pMHZwSm4Gxl5By/itxNF2/VCyuu/4N MWQ7+OkNgkXwJ+fi3NSma8b4M2vZBwxz56oqrqLDhYK5oA6YkCej1tk5ijT0FSRl 773pqTXswYlxTOVKJeDbZrlsb15h1Sov7KYWx7iUd9Ed2Ryz5Wk+d3OU7plbJ9f0 UMEvJolMNa1slO4V1/ena7fo0f0FiYwlF8wfIIVfIP9JfyhZz05Sljxpzp8hlXmH tl0S3OEefnm/+xHLY4qygB1v68cnup53F38OeAcRG+7b8thpQNq2x1DOqSXkDT/j mQ987kN3PqOwY+QZXI2N6RqIWAw3I82dJwfVCtBWX28iqwjiiGN9c73DY8bant7u UBYqpNC8o6A86Qat/munSkPcnTy3PPdoSNrx4MtpM4cvYeoDlgZVbFoEGPx4D1R1 pYKBIIr3pFTKWWh0oPk3c+a/ODpsnoMT9iVoHhIvn23ROgcTjr4= =WU0l -----END PGP SIGNATURE----- --ukndg6ovr6n4rtgo--