From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] sky2: Replace mdelay with msleep in sky2_vpd_wait Date: Tue, 02 Jan 2018 12:27:53 -0500 (EST) Message-ID: <20180102.122753.680821948903803520.davem@davemloft.net> References: <1514632187-14849-1-git-send-email-baijiaju1990@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: mlindner@marvell.com, stephen@networkplumber.org, shemminger@linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: baijiaju1990@gmail.com Return-path: In-Reply-To: <1514632187-14849-1-git-send-email-baijiaju1990@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Jia-Ju Bai Date: Sat, 30 Dec 2017 19:09:47 +0800 > sky2_vpd_wait is not called in an interrupt handler nor holding a spinlock. > The function mdelay in it can be replaced with msleep, to reduce busy wait. > > Signed-off-by: Jia-Ju Bai Applied.