From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] ip6_tunnel: allow ip6gre dev mtu to be set below 1280 Date: Tue, 02 Jan 2018 12:36:40 -0500 (EST) Message-ID: <20180102.123640.1005693862725388582.davem@davemloft.net> References: <2593c4a11b5ea0cf4efbec5517b7adec72ab4c17.1514184312.git.lucien.xin@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: lucien.xin@gmail.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:50078 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751059AbeABRgl (ORCPT ); Tue, 2 Jan 2018 12:36:41 -0500 In-Reply-To: <2593c4a11b5ea0cf4efbec5517b7adec72ab4c17.1514184312.git.lucien.xin@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Xin Long Date: Mon, 25 Dec 2017 14:45:12 +0800 > Commit 582442d6d5bc ("ipv6: Allow the MTU of ipip6 tunnel to be set > below 1280") fixed a mtu setting issue. It works for ipip6 tunnel. > > But ip6gre dev updates the mtu also with ip6_tnl_change_mtu. Since > the inner packet over ip6gre can be ipv4 and it's mtu should also > be allowed to set below 1280, the same issue also exists on ip6gre. > > This patch is to fix it by simply changing to check if parms.proto > is IPPROTO_IPV6 in ip6_tnl_change_mtu instead, to make ip6gre to > go to 'else' branch. > > Signed-off-by: Xin Long Applied.