From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] net/sched: Fix update of lastuse in act modules implementing stats_update Date: Tue, 02 Jan 2018 13:28:54 -0500 (EST) Message-ID: <20180102.132854.1445910631179933564.davem@davemloft.net> References: <1514267331-18753-1-git-send-email-roid@mellanox.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, paulb@mellanox.com, jiri@mellanox.com, xiyou.wangcong@gmail.com, jhs@mojatatu.com, ogerlitz@mellanox.com To: roid@mellanox.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:50664 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751029AbeABS24 (ORCPT ); Tue, 2 Jan 2018 13:28:56 -0500 In-Reply-To: <1514267331-18753-1-git-send-email-roid@mellanox.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Roi Dayan Date: Tue, 26 Dec 2017 07:48:51 +0200 > We need to update lastuse to to the most updated value between what > is already set and the new value. > If HW matching fails, i.e. because of an issue, the stats are not updated > but it could be that software did match and updated lastuse. > > Fixes: 5712bf9c5c30 ("net/sched: act_mirred: Use passed lastuse argument") > Fixes: 9fea47d93bcc ("net/sched: act_gact: Update statistics when offloaded to hardware") > Signed-off-by: Roi Dayan > Reviewed-by: Paul Blakey > Acked-by: Jiri Pirko Applied and queued up for -stable.