From: David Miller <davem@davemloft.net>
To: brendan.d.gregg@gmail.com
Cc: laoar.shao@gmail.com, songliubraving@fb.com,
marcelo.leitner@gmail.com, rostedt@goodmis.org,
bgregg@netflix.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 net-next 2/5] net: tracepoint: replace tcp_set_state tracepoint with inet_sock_set_state tracepoint
Date: Tue, 02 Jan 2018 14:52:08 -0500 (EST) [thread overview]
Message-ID: <20180102.145208.2297543449462978661.davem@davemloft.net> (raw)
In-Reply-To: <CAE40pddorDmoaGn2og-7u7vxpDY8uiWN8qEbQ05YYnK8f0Q_XQ@mail.gmail.com>
From: Brendan Gregg <brendan.d.gregg@gmail.com>
Date: Tue, 2 Jan 2018 11:46:26 -0800
> If I'm to use sock:inet_sock_set_state for TCP tracing, I'd like
> sk->sk_protocol exposed as a tracepoint argument so I can match on
> IPPROTO_TCP.
Agreed.
next prev parent reply other threads:[~2018-01-02 19:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-20 3:12 [PATCH v3 net-next 0/5] replace tcp_set_state tracepoint with inet_sock_set_state Yafang Shao
2017-12-20 3:12 ` [PATCH v3 net-next 1/5] tcp: Export to userspace the TCP state names for the trace events Yafang Shao
2017-12-20 3:12 ` [PATCH v3 net-next 2/5] net: tracepoint: replace tcp_set_state tracepoint with inet_sock_set_state tracepoint Yafang Shao
2017-12-30 22:33 ` Brendan Gregg
2017-12-31 3:06 ` Yafang Shao
2018-01-02 19:46 ` Brendan Gregg
2018-01-02 19:52 ` David Miller [this message]
2018-01-03 1:48 ` Yafang Shao
2017-12-20 3:12 ` [PATCH v3 net-next 3/5] net: sock: replace sk_state_load with inet_sk_state_load and remove sk_state_store Yafang Shao
2017-12-20 3:12 ` [PATCH v3 net-next 4/5] net: tracepoint: using sock_set_state tracepoint to trace DCCP state transition Yafang Shao
2017-12-20 3:12 ` [PATCH v3 net-next 5/5] net: tracepoint: using sock_set_state tracepoint to trace SCTP " Yafang Shao
2017-12-20 19:00 ` [PATCH v3 net-next 0/5] replace tcp_set_state tracepoint with inet_sock_set_state David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180102.145208.2297543449462978661.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bgregg@netflix.com \
--cc=brendan.d.gregg@gmail.com \
--cc=laoar.shao@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox