netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] i40e: Delete an error message for a failed memory allocation in i40e_init_interrupt_scheme()
@ 2018-01-01 19:43 SF Markus Elfring
  2018-01-02 19:56 ` [Intel-wired-lan] " Jesse Brandeburg
  0 siblings, 1 reply; 2+ messages in thread
From: SF Markus Elfring @ 2018-01-01 19:43 UTC (permalink / raw)
  To: netdev, intel-wired-lan, Jeff Kirsher; +Cc: LKML, kernel-janitors

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 1 Jan 2018 20:38:14 +0100

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/net/ethernet/intel/i40e/i40e_main.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
index 4a964d6e4a9e..fd9ac22ee65a 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_main.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
@@ -10445,10 +10445,9 @@ static int i40e_init_interrupt_scheme(struct i40e_pf *pf)
 	/* set up vector assignment tracking */
 	size = sizeof(struct i40e_lump_tracking) + (sizeof(u16) * vectors);
 	pf->irq_pile = kzalloc(size, GFP_KERNEL);
-	if (!pf->irq_pile) {
-		dev_err(&pf->pdev->dev, "error allocating irq_pile memory\n");
+	if (!pf->irq_pile)
 		return -ENOMEM;
-	}
+
 	pf->irq_pile->num_entries = vectors;
 	pf->irq_pile->search_hint = 0;
 
-- 
2.15.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Intel-wired-lan] [PATCH] i40e: Delete an error message for a failed memory allocation in i40e_init_interrupt_scheme()
  2018-01-01 19:43 [PATCH] i40e: Delete an error message for a failed memory allocation in i40e_init_interrupt_scheme() SF Markus Elfring
@ 2018-01-02 19:56 ` Jesse Brandeburg
  0 siblings, 0 replies; 2+ messages in thread
From: Jesse Brandeburg @ 2018-01-02 19:56 UTC (permalink / raw)
  To: SF Markus Elfring
  Cc: netdev, intel-wired-lan, Jeff Kirsher, kernel-janitors, LKML,
	jesse.brandeburg

On Mon, 1 Jan 2018 20:43:35 +0100
SF Markus Elfring <elfring@users.sourceforge.net> wrote:

> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Mon, 1 Jan 2018 20:38:14 +0100
> 
> Omit an extra message for a memory allocation failure in this function.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>

Thanks for the patch.

Acked-by: Jesse Brandeburg <jesse.brandeburg@intel.com>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-01-02 19:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-01 19:43 [PATCH] i40e: Delete an error message for a failed memory allocation in i40e_init_interrupt_scheme() SF Markus Elfring
2018-01-02 19:56 ` [Intel-wired-lan] " Jesse Brandeburg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).