From: Andrew Lunn <andrew@lunn.ch>
To: Russell King - ARM Linux <linux@armlinux.org.uk>
Cc: Florian Fainelli <f.fainelli@gmail.com>, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 4/7] net: phy: add paged phy register accessors
Date: Tue, 2 Jan 2018 14:14:26 +0100 [thread overview]
Message-ID: <20180102131426.GA15036@lunn.ch> (raw)
In-Reply-To: <20180102105020.GA21998@n2100.armlinux.org.uk>
> I've decided to solve this by changing it to:
>
> + * phy_restore_page() must always be called after this, irrespective
> + * of success or failure of this call.
>
> iow, not explaining /why/.
Hi Russell
That is fine by my. A quick read of the code makes it clear why.
Andrew
next prev parent reply other threads:[~2018-01-02 13:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-29 12:30 [PATCH net-next 0/7] Resolve races in phy accessors Russell King - ARM Linux
2017-12-29 12:30 ` [PATCH net-next 1/7] net: mdiobus: add unlocked accessors Russell King
2017-12-29 12:30 ` [PATCH net-next 2/7] net: phy: use unlocked accessors for indirect MMD accesses Russell King
2017-12-29 12:30 ` [PATCH net-next 3/7] net: phy: add unlocked accessors Russell King
2017-12-29 12:31 ` [PATCH net-next 4/7] net: phy: add paged phy register accessors Russell King
2017-12-31 8:10 ` Andrew Lunn
2017-12-31 10:07 ` Russell King - ARM Linux
2018-01-02 10:50 ` Russell King - ARM Linux
2018-01-02 13:14 ` Andrew Lunn [this message]
2017-12-29 12:31 ` [PATCH net-next 5/7] net: phy: marvell: fix paged access races Russell King
2017-12-29 12:31 ` [PATCH net-next 6/7] net: phy: add phy_modify() accessor Russell King
2017-12-29 12:31 ` [PATCH net-next 7/7] net: phy: convert read-modify-write to phy_modify() Russell King
2017-12-30 16:18 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180102131426.GA15036@lunn.ch \
--to=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).