From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH net-next 4/7] net: phy: add paged phy register accessors
Date: Tue, 2 Jan 2018 14:14:26 +0100
Message-ID: <20180102131426.GA15036@lunn.ch>
References: <20171229123024.GZ10595@n2100.armlinux.org.uk>
 <E1eUtoW-0002A1-TM@rmk-PC.armlinux.org.uk>
 <20171231081039.GA14485@lunn.ch>
 <20171231100714.GD10595@n2100.armlinux.org.uk>
 <20180102105020.GA21998@n2100.armlinux.org.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Florian Fainelli <f.fainelli@gmail.com>, netdev@vger.kernel.org
To: Russell King - ARM Linux <linux@armlinux.org.uk>
Return-path: <netdev-owner@vger.kernel.org>
Received: from vps0.lunn.ch ([185.16.172.187]:50282 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751612AbeABNOb (ORCPT <rfc822;netdev@vger.kernel.org>);
        Tue, 2 Jan 2018 08:14:31 -0500
Content-Disposition: inline
In-Reply-To: <20180102105020.GA21998@n2100.armlinux.org.uk>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

> I've decided to solve this by changing it to:
> 
> + * phy_restore_page() must always be called after this, irrespective
> + * of success or failure of this call.
> 
> iow, not explaining /why/.

Hi Russell

That is fine by my. A quick read of the code makes it clear why.

     Andrew