From: David Miller <davem@davemloft.net>
To: nhorman@tuxdriver.com
Cc: netdev@vger.kernel.org, nhorman@redhat.com,
klassert@mathematik.tu-chemnitz.de
Subject: Re: [PATCH] 3c59x: fix missing dma_mapping_error check
Date: Wed, 03 Jan 2018 09:53:24 -0500 (EST) [thread overview]
Message-ID: <20180103.095324.2019351026018947051.davem@davemloft.net> (raw)
In-Reply-To: <20180103104204.GB18309@hmswarspite.think-freely.org>
From: Neil Horman <nhorman@tuxdriver.com>
Date: Wed, 3 Jan 2018 05:42:04 -0500
> On Tue, Jan 02, 2018 at 09:48:27PM -0500, David Miller wrote:
>> And for the RX cases, it allows the RX ring to deplete to empty which
>> tends to hang most chips. You need to make the DMA failure detection
>> early and recycle the RX buffer back to the chip instead of passing
>> it up to the stack.
>>
> Strictly speaking, I think we're ok here, because the dirty_rx counter creates a
> contiguous area to refill, and we will just pick up where we left off on the
> next napi poll.
If you continually fail the mappings, even NAPI poll, eventually the
RX ring will empty.
I don't think we're ok here.
next prev parent reply other threads:[~2018-01-03 14:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-29 14:51 3c59x: pci_unmap_single() oops tedheadster
2017-12-29 16:40 ` [PATCH] 3c59x: fix missing dma_mapping_error check Neil Horman
2018-01-03 2:48 ` David Miller
2018-01-03 10:42 ` Neil Horman
2018-01-03 14:53 ` David Miller [this message]
2018-01-03 14:44 ` [PATCHv2] 3c59x: fix missing dma_mapping_error check and bad ring refill logic Neil Horman
2018-01-03 14:58 ` David Miller
2018-01-03 15:13 ` Neil Horman
2018-01-03 15:26 ` David Miller
2018-01-03 15:28 ` David Miller
2018-01-03 16:41 ` Neil Horman
2018-01-03 18:09 ` [PATCHv3] " Neil Horman
2018-01-03 18:44 ` David Miller
2018-01-22 6:27 ` tedheadster
2018-01-22 12:36 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180103.095324.2019351026018947051.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=klassert@mathematik.tu-chemnitz.de \
--cc=netdev@vger.kernel.org \
--cc=nhorman@redhat.com \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).