From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCHv2] 3c59x: fix missing dma_mapping_error check and bad ring refill logic Date: Wed, 03 Jan 2018 09:58:49 -0500 (EST) Message-ID: <20180103.095849.985156664792555290.davem@davemloft.net> References: <20180103144415.13446-1-nhorman@tuxdriver.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, tedheadster@gmail.com, nhorman@redhat.com, klassert@mathematik.tu-chemnitz.de To: nhorman@tuxdriver.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:60710 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751861AbeACO6v (ORCPT ); Wed, 3 Jan 2018 09:58:51 -0500 In-Reply-To: <20180103144415.13446-1-nhorman@tuxdriver.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Neil Horman Date: Wed, 3 Jan 2018 09:44:15 -0500 > A few spots in 3c59x missed calls to dma_mapping_error checks, casuing > WARN_ONS to trigger. Clean those up. While we're at it, refactor the > refill code a bit so that if skb allocation or dma mapping fails, we > recycle the existing buffer. This prevents holes in the rx ring, and > makes for much simpler logic > > Note: This is compile only tested. Ted, if you could run this and > confirm that it continues to work properly, I would appreciate it, as I > currently don't have access to this hardware > > Signed-off-by: Neil Horman > CC: Steffen Klassert > CC: "David S. Miller" > Reported-by: tedheadster@gmail.com See my other reply. Your RX handling must become more sophisticated. This is exactly what we tell driver authors to do. If you cannot allocate or DMA map a replacement RX buffer, you _MUST_ recycle the existing buffer back to the chip rather than pass it up to the stack. Thank you.