From: Guillaume Nault <g.nault@alphalink.fr>
To: James Chapman <jchapman@katalix.com>
Cc: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, Hangbin Liu <liuhangbin@gmail.com>
Subject: Re: [PATCH net-next 2/2] l2tp: add peer_offset parameter
Date: Wed, 3 Jan 2018 15:27:24 +0100 [thread overview]
Message-ID: <20180103142724.GE1402@alphalink.fr> (raw)
In-Reply-To: <d6570c0f-2e60-6ea9-d277-27a848a49dd2@katalix.com>
On Tue, Jan 02, 2018 at 08:59:44PM +0000, James Chapman wrote:
> I just realised the peer_offset attribute changes are already applied in
> net-next. (I missed these when they were submitted just before Christmas.)
> Should these commits be reverted? We probably don't want v4.15 to get an
> additional l2tp peer_offset attribute if we are going to remove it and the
> rest of the code supporting configurable offset attributes in the next
> release.
>
Yes, I agree for a revert. I'm sorry for Lorenzo's work but I'd rather
not expand the user API in this direction.
next prev parent reply other threads:[~2018-01-03 14:27 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-22 14:10 [PATCH net-next 0/2] l2tp: fix offset/peer_offset conf parameters Lorenzo Bianconi
2017-12-22 14:10 ` [PATCH net-next 1/2] l2tp: fix missing print session offset info Lorenzo Bianconi
2017-12-22 14:10 ` [PATCH net-next 2/2] l2tp: add peer_offset parameter Lorenzo Bianconi
2017-12-28 14:53 ` Guillaume Nault
2017-12-28 18:23 ` Lorenzo Bianconi
2017-12-28 19:45 ` Guillaume Nault
2017-12-29 18:53 ` James Chapman
2017-12-29 22:21 ` Lorenzo Bianconi
2018-01-02 18:05 ` Guillaume Nault
2018-01-02 19:28 ` Lorenzo Bianconi
2018-01-02 20:18 ` James Chapman
2018-01-03 14:16 ` Guillaume Nault
2018-01-03 15:06 ` Lorenzo Bianconi
2018-01-03 16:35 ` Guillaume Nault
2018-01-08 17:27 ` Lorenzo Bianconi
2018-01-02 20:08 ` James Chapman
2018-01-02 20:59 ` James Chapman
2018-01-03 14:27 ` Guillaume Nault [this message]
2018-01-02 17:50 ` Guillaume Nault
2018-01-02 20:08 ` James Chapman
2017-12-27 17:12 ` [PATCH net-next 0/2] l2tp: fix offset/peer_offset conf parameters David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180103142724.GE1402@alphalink.fr \
--to=g.nault@alphalink.fr \
--cc=davem@davemloft.net \
--cc=jchapman@katalix.com \
--cc=liuhangbin@gmail.com \
--cc=lorenzo.bianconi@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).