From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guillaume Nault Subject: Re: [PATCH net-next 2/2] l2tp: add peer_offset parameter Date: Wed, 3 Jan 2018 15:27:24 +0100 Message-ID: <20180103142724.GE1402@alphalink.fr> References: <20171228145340.GA1292@alphalink.fr> <20171228182347.GA8732@localhost.localdomain> <20171228194556.GA1256@alphalink.fr> <27e0a7c8-b95b-04eb-d808-bcae67e417b1@katalix.com> <20180102180557.GB1402@alphalink.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Lorenzo Bianconi , "David S. Miller" , netdev@vger.kernel.org, Hangbin Liu To: James Chapman Return-path: Received: from zimbra.alphalink.fr ([217.15.80.77]:33040 "EHLO zimbra.alphalink.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750857AbeACO11 (ORCPT ); Wed, 3 Jan 2018 09:27:27 -0500 Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Tue, Jan 02, 2018 at 08:59:44PM +0000, James Chapman wrote: > I just realised the peer_offset attribute changes are already applied in > net-next. (I missed these when they were submitted just before Christmas.) > Should these commits be reverted? We probably don't want v4.15 to get an > additional l2tp peer_offset attribute if we are going to remove it and the > rest of the code supporting configurable offset attributes in the next > release. > Yes, I agree for a revert. I'm sorry for Lorenzo's work but I'd rather not expand the user API in this direction.