From: Andrew Lunn <andrew@lunn.ch>
To: Antoine Tenart <antoine.tenart@free-electrons.com>
Cc: davem@davemloft.net, kishon@ti.com,
gregory.clement@free-electrons.com, linux@armlinux.org.uk,
mw@semihalf.com, stefanc@marvell.com, ymarkman@marvell.com,
thomas.petazzoni@free-electrons.com,
miquel.raynal@free-electrons.com, nadavh@marvell.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 4/4] net: mvpp2: 2500baseX support
Date: Wed, 3 Jan 2018 16:20:36 +0100 [thread overview]
Message-ID: <20180103152036.GC3401@lunn.ch> (raw)
In-Reply-To: <20180103150750.12974-5-antoine.tenart@free-electrons.com>
> @@ -4612,6 +4616,9 @@ static int mvpp22_comphy_init(struct mvpp2_port *port)
> case PHY_INTERFACE_MODE_1000BASEX:
> mode = PHY_MODE_SGMII;
> break;
> + case PHY_INTERFACE_MODE_2500BASEX:
> + mode = PHY_MODE_2500SGMII;
> + break;
I think this is the source of confusion with linux/phy.h and
linux/phy/phy.h.
What would PHY_INTERFACE_MODE_2500SGMII use?
Where is this all getting confused? Should the caller to
mvpp22_comphy_init() actually be passing PHY_INTERFACE_MODE_2500SGMII?
What is the MAC actually doing at this point? 2500BASEX or 2500SGMII?
At minimum there needs to be a comment that this is not a typ0,
otherwise you are going to get patches submitted to 'fix' this.
Thanks
Andrew
next prev parent reply other threads:[~2018-01-03 15:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-03 15:07 [PATCH net-next v2 0/4] net: mvpp2: 1000BaseX and 2000BaseX support Antoine Tenart
2018-01-03 15:07 ` [PATCH net-next v2 1/4] phy: add 2.5G SGMII mode to the phy_mode enum Antoine Tenart
2018-01-03 15:07 ` [PATCH net-next v2 2/4] phy: cp110-comphy: 2.5G SGMII mode Antoine Tenart
2018-01-03 15:07 ` [PATCH net-next v2 3/4] net: mvpp2: 1000baseX support Antoine Tenart
2018-01-03 15:07 ` [PATCH net-next v2 4/4] net: mvpp2: 2500baseX support Antoine Tenart
2018-01-03 15:20 ` Andrew Lunn [this message]
2018-01-03 15:32 ` Antoine Tenart
2018-01-03 15:50 ` [EXT] " Stefan Chulski
2018-01-03 15:53 ` Andrew Lunn
2018-01-03 16:11 ` Stefan Chulski
2018-01-03 18:08 ` Antoine Tenart
2018-01-03 18:05 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180103152036.GC3401@lunn.ch \
--to=andrew@lunn.ch \
--cc=antoine.tenart@free-electrons.com \
--cc=davem@davemloft.net \
--cc=gregory.clement@free-electrons.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=miquel.raynal@free-electrons.com \
--cc=mw@semihalf.com \
--cc=nadavh@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=stefanc@marvell.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=ymarkman@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).