From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Kicinski Subject: Re: [patch net-next v4 00/10] net: sched: allow qdiscs to share filter block instances Date: Wed, 3 Jan 2018 15:51:52 -0800 Message-ID: <20180103155152.7e94a295@cakuba.netronome.com> References: <20171223155436.9014-1-jiri@resnulli.us> <20171224071956.GA1883@nanopsycho> <780a80d0-9384-ae34-4cab-3070b004b64e@gmail.com> <20171225102346.GB1885@nanopsycho> <20180102194944.GG2051@nanopsycho.orion> <20180103094025.GA2067@nanopsycho.orion> <20180103172209.GD2067@nanopsycho.orion> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: David Ahern , netdev@vger.kernel.org, davem@davemloft.net, jhs@mojatatu.com, xiyou.wangcong@gmail.com, mlxsw@mellanox.com, andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com, michael.chan@broadcom.com, ganeshgr@chelsio.com, saeedm@mellanox.com, matanb@mellanox.com, leonro@mellanox.com, idosch@mellanox.com, simon.horman@netronome.com, pieter.jansenvanvuuren@netronome.com, john.hurley@netronome.com, alexander.h.duyck@intel.com, ogerlitz@mellanox.com, john.fastabend@gmail.com, daniel@iogearbox.net To: Jiri Pirko Return-path: Received: from mx3.wp.pl ([212.77.101.9]:38632 "EHLO mx3.wp.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750913AbeACXwE (ORCPT ); Wed, 3 Jan 2018 18:52:04 -0500 In-Reply-To: <20180103172209.GD2067@nanopsycho.orion> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, 3 Jan 2018 18:22:09 +0100, Jiri Pirko wrote: > However I don't agree about breaking the existing filter add and show > and also imposibility to make not-shared block shared in the runtime > before defining it first. FWIW I would agree with David that allowing add on a shared block modify filters on another interface can break existing users. (No opinion on dump and lifetime).