From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [patch net-next v2 00/10] Add support for resource abstraction Date: Wed, 3 Jan 2018 19:36:36 +0100 Message-ID: <20180103183636.GF2067@nanopsycho.orion> References: <20171226112359.5313-1-jiri@resnulli.us> <977652df-a0ed-d1a5-f299-1dc433ebd337@mellanox.com> <96389ae0-e038-8a26-84ea-0cf1b9fa0a05@cumulusnetworks.com> <0f861e90-63d3-2666-ef2d-0fc91beae957@mellanox.com> <2f0f6007-64a1-0d0d-eff2-2e5ba6fdb701@cumulusnetworks.com> <20180103181744.GE2067@nanopsycho.orion> <49c72225-6437-54d5-a046-96fff5b65ce9@cumulusnetworks.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Arkadi Sharshevsky , netdev@vger.kernel.org, roopa@cumulusnetworks.com, davem@davemloft.net, mlxsw@mellanox.com, andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com, michael.chan@broadcom.com, ganeshgr@chelsio.com, saeedm@mellanox.com, matanb@mellanox.com, leonro@mellanox.com, idosch@mellanox.com, jakub.kicinski@netronome.com, ast@kernel.org, daniel@iogearbox.net, simon.horman@netronome.com, pieter.jansenvanvuuren@netronome.com, john.hurley@netronome.com, alexander.h.duyck@intel.com, linville@tuxdriver.com, gospo@broadcom.com, steven.lin1@broadcom.com, yuvalm@mellanox.com, ogerlitz@mellanox.com To: David Ahern Return-path: Received: from mail-wr0-f195.google.com ([209.85.128.195]:41175 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751159AbeACSgi (ORCPT ); Wed, 3 Jan 2018 13:36:38 -0500 Received: by mail-wr0-f195.google.com with SMTP id p69so2505909wrb.8 for ; Wed, 03 Jan 2018 10:36:38 -0800 (PST) Content-Disposition: inline In-Reply-To: <49c72225-6437-54d5-a046-96fff5b65ce9@cumulusnetworks.com> Sender: netdev-owner@vger.kernel.org List-ID: Wed, Jan 03, 2018 at 07:29:46PM CET, dsa@cumulusnetworks.com wrote: >On 1/3/18 11:17 AM, Jiri Pirko wrote: >> Wed, Jan 03, 2018 at 07:14:16PM CET, dsa@cumulusnetworks.com wrote: >>> On 1/3/18 11:05 AM, Arkadi Sharshevsky wrote: >>>> As I stated this is a user-space bug which I fixed, and updated my repo >>>> so please pull. Devlink uses mnl,and currently mnl does not support >>>> extended ack. I added support for this in my local ver of libmnl: >>>> >>>> https://github.com/arkadis/libmnl.git >>>> >>>> On branch master, so you can check it out. Besides this bugs, which were >>>> userspace, can please specify what are the pending problems from your >>>> point of view? Thanks! >>> >>> devlink is in iproute2 package and it has extack support. See 'git log >>> lib/libnetlink.c' >> >> Dave, devlink uses libmnl. >> > >Now I remember. You wrote it independently and but needed iproute2 be a >delivery vehicle. It uses none of the common infrastructure from >iproute2. Could we make this more difficult .... Feel free to rewrite it to use lib/libnetlink.c. Should not be that hard. Note that at the time I was pushing devlink userspace, tipc also used libmnl as a part of iproute2, so devlink was not the first one. That is why I decided not to rewrite. As of the rest of the "common infrastructure", what exactly do you have in mind? > >Sometime in the next day I will jump through the hoops to get a proper >devlink command.