From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [patch net-next v4 00/10] net: sched: allow qdiscs to share filter block instances Date: Thu, 04 Jan 2018 10:45:21 -0500 (EST) Message-ID: <20180104.104521.1842347831974087325.davem@davemloft.net> References: <20180103230658.595eac7d@cakuba.netronome.com> <20180104101257.GA2213@nanopsycho> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: jiri@resnulli.us, kubakici@wp.pl, dsahern@gmail.com, netdev@vger.kernel.org, xiyou.wangcong@gmail.com, mlxsw@mellanox.com, andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com, michael.chan@broadcom.com, ganeshgr@chelsio.com, saeedm@mellanox.com, matanb@mellanox.com, leonro@mellanox.com, idosch@mellanox.com, simon.horman@netronome.com, pieter.jansenvanvuuren@netronome.com, john.hurley@netronome.com, alexander.h.duyck@intel.com, ogerlitz@mellanox.com, john.fastabend@gmail.com, daniel@iogearbox.net To: jhs@mojatatu.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:47226 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753259AbeADPpZ (ORCPT ); Thu, 4 Jan 2018 10:45:25 -0500 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: From: Jamal Hadi Salim Date: Thu, 4 Jan 2018 07:41:54 -0500 > I agree with Jiri - if you consciously choose to share there should > be no suprises with what filters get applied. Wrong. It is not always the case that the two entities making changes are coordinated explicitly. Block operations shared across devices must therefore be _explicit_. Any other behavior will result in surprised and unintended consequences.