From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] net: stmmac: enable EEE in MII, GMII or RGMII only Date: Thu, 04 Jan 2018 14:02:26 -0500 (EST) Message-ID: <20180104.140226.949194351555593980.davem@davemloft.net> References: <20180103154629.1433-1-jbrunet@baylibre.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, peppe.cavallaro@st.com, alexandre.torgue@st.com, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org To: jbrunet@baylibre.com Return-path: In-Reply-To: <20180103154629.1433-1-jbrunet@baylibre.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Jerome Brunet Date: Wed, 3 Jan 2018 16:46:29 +0100 > Note in the databook - Section 4.4 - EEE : > " The EEE feature is not supported when the MAC is configured to use the > TBI, RTBI, SMII, RMII or SGMII single PHY interface. Even if the MAC > supports multiple PHY interfaces, you should activate the EEE mode only > when the MAC is operating with GMII, MII, or RGMII interface." > > Applying this restriction solves a stability issue observed on Amlogic > gxl platforms operating with RMII interface and the internal PHY. > > Fixes: 83bf79b6bb64 ("stmmac: disable at run-time the EEE if not supported") > Signed-off-by: Jerome Brunet > Tested-by: Arnaud Patard Applied and queued up for -stable, thanks.