From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH net] ipv6: fix general protection fault in fib6_add()
Date: Thu, 04 Jan 2018 14:30:03 -0500 (EST)
Message-ID: <20180104.143003.729989900723159013.davem@davemloft.net>
References: <20180103221159.159648-1-tracywwnj@gmail.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, kafai@fb.com, dsahern@gmail.com
To: weiwan@google.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:50026 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752271AbeADTaE (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 4 Jan 2018 14:30:04 -0500
In-Reply-To: <20180103221159.159648-1-tracywwnj@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Wei Wang <weiwan@google.com>
Date: Wed,  3 Jan 2018 14:11:59 -0800

> From: Wei Wang <weiwan@google.com>
> 
> In fib6_add(), pn could be NULL if fib6_add_1() failed to return a fib6
> node. Checking pn != fn before accessing pn->leaf makes sure pn is not
> NULL.
> This fixes the following GPF reported by syzkaller:
 ...
> Reported-by: syzbot <syzkaller@googlegroups.com>
> Fixes: 66f5d6ce53e6 ("ipv6: replace rwlock with rcu and spinlock in fib6_table")
> Signed-off-by: Wei Wang <weiwan@google.com>

Applied, thanks.