From: Andrew Lunn <andrew@lunn.ch>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Russell King <rmk+kernel@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: Issue with commit fea23fb591cc "net: phy: convert read-modify-write to phy_modify()"
Date: Thu, 4 Jan 2018 13:59:57 +0100 [thread overview]
Message-ID: <20180104125957.GH6671@lunn.ch> (raw)
In-Reply-To: <8cf4bdaa-bd05-1962-f1d0-6cb84db31588@googlemail.com>
On Thu, Jan 04, 2018 at 08:00:53AM +0100, Heiner Kallweit wrote:
> Parameter mask of phy_modify() holds the bits to be cleared.
> In the mentioned commit parameter mask seems to be inverted in
> few cases, what IMO is wrong (see example).
> Maybe I miss something, could you please check?
Hi Heiner
mdio reads/writes can be traced via events. Could you log them for
your board, with and without this patch applied. Hopefully the traces
are similar enough that issues like this can be spotted.
Thanks
Andrew
prev parent reply other threads:[~2018-01-04 13:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-04 7:00 Issue with commit fea23fb591cc "net: phy: convert read-modify-write to phy_modify()" Heiner Kallweit
2018-01-04 11:44 ` Russell King - ARM Linux
2018-01-04 19:16 ` Heiner Kallweit
2018-01-05 0:44 ` Ivan Khoronzhuk
2018-01-05 1:02 ` Russell King - ARM Linux
2018-01-04 12:59 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180104125957.GH6671@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).