From: Andrew Lunn <andrew@lunn.ch>
To: Russell King - ARM Linux <linux@armlinux.org.uk>
Cc: David Miller <davem@davemloft.net>,
Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
Florian Fainelli <f.fainelli@gmail.com>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 0/5] Export SERDES stats via ethtool -S
Date: Thu, 4 Jan 2018 22:07:20 +0100 [thread overview]
Message-ID: <20180104210720.GT3401@lunn.ch> (raw)
In-Reply-To: <20180103175832.GJ28752@n2100.armlinux.org.uk>
> Hi Andrew,
>
> Isn't the serdes interface just a normal PHY - the register set in
> Viviens debugfs patch certainly looks like an 88e1545 in one of the
> switches I've here (I think on the dev rev B). Is there a reason why
> this PHY isn't visible as a normal PHY, just like we export the other
> internal PHYs?
Humm, interesting idea. Yes, it looks like a normal PHY. It is however
not contiguous to the internal PHYs on the 6352. You probably can
however see it, if you look on the MDIO bus, at address 0xf.
Depends on what mode the ports are in, the SERDES can be connected to
either port 4 or 5. Port 5 does not have an internal PHY, but port 4
does. We could determine what port is using the SERDES, and redirect
PHY read/writes to the SERDES interface. But it gets a bit complex for
port 4, since it can use either copper or SERDES depending on which
comes up first. So suppose you need to be able to see both the copper
PHY and the SERDES, so you can initialize them both, in order for one
to actually come up.
Andrew
prev parent reply other threads:[~2018-01-04 21:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-03 14:09 [PATCH net-next 0/5] Export SERDES stats via ethtool -S Andrew Lunn
2018-01-03 14:09 ` [PATCH net-next 1/5] dsa: Pass the port to get_sset_count() Andrew Lunn
2018-01-03 14:41 ` Vivien Didelot
2018-01-03 14:09 ` [PATCH net-next 2/5] net: dsa: mv88e6xxx: Hold mutex while doing stats operations Andrew Lunn
2018-01-03 14:32 ` Vivien Didelot
2018-01-03 15:02 ` Andrew Lunn
2018-01-03 15:43 ` Vivien Didelot
2018-01-03 14:09 ` [PATCH net-next 3/5] net: dsa: mv88e6xxx: Allow the SERDES interfaces to have statistics Andrew Lunn
2018-01-03 14:54 ` Vivien Didelot
2018-01-03 14:09 ` [PATCH net-next 4/5] net: dsa: mv88e6xxx: Add helper to determining if port has SERDES Andrew Lunn
2018-01-03 15:00 ` Vivien Didelot
2018-01-03 14:09 ` [PATCH net-next 5/5] net: dsa: mv88e6xxx: Get mv88e6352 SERDES statistics Andrew Lunn
2018-01-03 15:31 ` Vivien Didelot
2018-01-03 17:58 ` [PATCH net-next 0/5] Export SERDES stats via ethtool -S Russell King - ARM Linux
2018-01-04 21:07 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180104210720.GT3401@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).