From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Gospodarek Subject: Re: [net-next 00/10] net: create dynamic software irq moderation library Date: Thu, 4 Jan 2018 17:46:44 -0500 Message-ID: <20180104224644.GB64505@C02RW35GFVH8> References: <1515097290-17470-1-git-send-email-andy@greyhouse.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Linux Netdev List , mchan@broadcom.com, Tal Gilboa , Or Gerlitz , Andy Gospodarek To: Or Gerlitz Return-path: Received: from mail-qt0-f173.google.com ([209.85.216.173]:33093 "EHLO mail-qt0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753152AbeADWqs (ORCPT ); Thu, 4 Jan 2018 17:46:48 -0500 Received: by mail-qt0-f173.google.com with SMTP id e2so3778381qti.0 for ; Thu, 04 Jan 2018 14:46:48 -0800 (PST) Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Thu, Jan 04, 2018 at 10:37:37PM +0200, Or Gerlitz wrote: > > net/mlx5e: move interrupt moderation structs to new file > > net/mlx5e: move interrupt moderation forward declarations > > net/mlx5e: remove rq references in mlx5e_rx_am > > net/mlx5e: move AM logic enums > > net/mlx5e: move generic functions to new file > > net/mlx5e: change Mellanox references in DIM code > > Hi, Andy && happy new 2018 -- this is indeed a nit, but I have > provided it to you twice (...), > please get the commit titles to align with what we do which is capital > letter after the net/mlx5e: prefix > > from: net/mlx5e: move interrupt moderation structs to new file > to: net/mlx5e: Move interrupt moderation structs to new file > > If you get other comments, just apply this for the next version, if everyone > is happy, that would be a very small effort to just fix and get that in.. Or, you did mention this part and I'm _really_ sorry to forgot to add the capitalization. I will do that if there is a v2 (which is looks like there might be since I cannot spell 'Maintained' correctly.