From: David Miller <davem@davemloft.net>
To: edumazet@google.com
Cc: natale.patriciello@gmail.com, netdev@vger.kernel.org,
carloaugusto.grazia@unimore.it
Subject: Re: [RFC PATCH 1/3] Revert "tcp: allow drivers to tweak TSQ logic"
Date: Fri, 05 Jan 2018 10:26:07 -0500 (EST) [thread overview]
Message-ID: <20180105.102607.1479150123989462300.davem@davemloft.net> (raw)
In-Reply-To: <CANn89iL7qzGG8G24dfMqZ1p5hXvLn2N0=Hm-t8n+T7qUCXe9gA@mail.gmail.com>
From: Eric Dumazet <edumazet@google.com>
Date: Fri, 5 Jan 2018 03:44:20 -0800
> On Fri, Jan 5, 2018 at 3:32 AM, Natale Patriciello
> <natale.patriciello@gmail.com> wrote:
>> There are a lot of drivers that are still outside the mainline, and it is
>> impossible to expect the authors (which in most cases do not maintain the
>> driver anymore) to check the best value for the device, and then to insert
>> it into the driver code. Moreover, if the users want to check or to use
>> other values, they have to recompile the driver (or the kernel).
>>
>
> This is nonsense
>
> I do not care of out of tree drivers.
>
> NACK.
Agreed, big NACK from me as well.
next prev parent reply other threads:[~2018-01-05 15:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-05 11:32 [RFC PATCH 0/3] tcp: allow user and drivers to tweak TSQ logic through sysctl knobs Natale Patriciello
2018-01-05 11:32 ` [RFC PATCH 1/3] Revert "tcp: allow drivers to tweak TSQ logic" Natale Patriciello
2018-01-05 11:44 ` Eric Dumazet
2018-01-05 15:26 ` David Miller [this message]
2018-01-05 11:32 ` [RFC PATCH 2/3] tcp: Negative values of sysctl_tcp_limit_output_bytes disable TSQ Natale Patriciello
2018-01-05 11:43 ` Eric Dumazet
2018-01-05 11:32 ` [RFC PATCH 3/3] tcp: Add tunable parameters for TSQ Natale Patriciello
2018-01-05 11:53 ` Eric Dumazet
2018-01-06 19:22 ` Natale Patriciello
2018-01-09 19:04 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180105.102607.1479150123989462300.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=carloaugusto.grazia@unimore.it \
--cc=edumazet@google.com \
--cc=natale.patriciello@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).