From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next 0/4] l2tp: remove configurable offset parameters Date: Fri, 05 Jan 2018 11:04:05 -0500 (EST) Message-ID: <20180105.110405.1664216604559089965.davem@davemloft.net> References: <1515019687-1556-1-git-send-email-jchapman@katalix.com> <20180104103228.GH1402@alphalink.fr> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: jchapman@katalix.com, netdev@vger.kernel.org, lorenzo.bianconi@redhat.com, liuhangbin@gmail.com To: g.nault@alphalink.fr Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:33456 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751784AbeAEQEJ (ORCPT ); Fri, 5 Jan 2018 11:04:09 -0500 In-Reply-To: <20180104103228.GH1402@alphalink.fr> Sender: netdev-owner@vger.kernel.org List-ID: From: Guillaume Nault Date: Thu, 4 Jan 2018 11:32:28 +0100 > On Wed, Jan 03, 2018 at 10:48:03PM +0000, James Chapman wrote: >> This patch series removes all code to support a configurable offset in >> transmitted l2tp packets. Code to handle this is incomplete and buggy >> and has been this way for years. If anyone tried to configure an >> offset, it would be ignored for L2TPv2 tunnels, or for L2TPv3 tunnels, >> could result in L2TPv3 packets being transmitted which are not >> compliant with L2TPv3 RFC3931. This patch series removes the support >> for configurable offsets. >> > Thanks for the detailed cover letter! > > There are a few more places talking about offsets: > * Description of SESSION_CREATE in include/uapi/linux/l2tp.h. > * Description of L2TPv3 packet format above l2tp_recv_common() in > net/l2tp/l2tp_core.c. > > I can submit a followup patch to remove them. > > Reviewed-by: Guillaume Nault > Tested-by: Guillaume Nault Series applied, thanks everyone.