From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next 1/6] net: Fix netdev_WARN_ONCE macro Date: Fri, 05 Jan 2018 13:35:19 -0500 (EST) Message-ID: <20180105.133519.1602365963790420581.davem@davemloft.net> References: <1515077763-27991-1-git-send-email-galp@mellanox.com> <1515077763-27991-2-git-send-email-galp@mellanox.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, tariqt@mellanox.com, saeedm@mellanox.com To: galp@mellanox.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:35308 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752038AbeAESfX (ORCPT ); Fri, 5 Jan 2018 13:35:23 -0500 In-Reply-To: <1515077763-27991-2-git-send-email-galp@mellanox.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Gal Pressman Date: Thu, 4 Jan 2018 16:55:58 +0200 > netdev_WARN_ONCE is broken (whoops..), fix it. You don't say how it is broken and how you are fixing that brokenness, and you must do this. Yes, if I stare at your patch for a few minutes I can see the missing "," but you could have saved everyone reviewing this patch (now and in the future) by writing a proper and complete commit message.