From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Kicinski Subject: Re: [PATCH bpf-next 02/16] bpf: array: move checks out of alloc function Date: Fri, 5 Jan 2018 09:40:28 -0800 Message-ID: <20180105094028.4cfe408e@cakuba.netronome.com> References: <20180105060931.30815-1-jakub.kicinski@netronome.com> <20180105060931.30815-3-jakub.kicinski@netronome.com> <20180105172100.mk2nhmutvcgplbja@ast-mbp> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, daniel@iogearbox.net, davem@davemloft.net, oss-drivers@netronome.com, tehnerd@fb.com To: Alexei Starovoitov Return-path: Received: from mail-qt0-f171.google.com ([209.85.216.171]:39651 "EHLO mail-qt0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751796AbeAERkd (ORCPT ); Fri, 5 Jan 2018 12:40:33 -0500 Received: by mail-qt0-f171.google.com with SMTP id k19so6589704qtj.6 for ; Fri, 05 Jan 2018 09:40:33 -0800 (PST) In-Reply-To: <20180105172100.mk2nhmutvcgplbja@ast-mbp> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, 5 Jan 2018 09:21:02 -0800, Alexei Starovoitov wrote: > On Thu, Jan 04, 2018 at 10:09:17PM -0800, Jakub Kicinski wrote: > > Use the new callback to perform allocation checks for array maps. > > The fd maps don't need a special allocation callback, they only > > need a special check callback. > > > > Signed-off-by: Jakub Kicinski > > Reviewed-by: Quentin Monnet > > LGTM > but I would like to hold on this set until we fix the fallout > from cpu bug. See my patch: https://patchwork.ozlabs.org/patch/855911/ > If we merge your set to bpf-next today we'll have very nasty > conflicts between bpf and bpf-next. > I'd like to fix everything necessary for these CVEs in bpf tree first > and get that merged all the way to bpf-next through Linus tree > before proceeding with this refactoring. > Ok? Makes perfect sense, I wasn't sure what's the plan about the CVEs. Thanks!