From: Stephen Hemminger <stephen@networkplumber.org>
To: Matthias Schiffer <mschiffer@universe-factory.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH iproute2] devlink, rdma, tipc: properly define TARGETS without HAVE_MNL
Date: Fri, 5 Jan 2018 16:34:26 -0800 [thread overview]
Message-ID: <20180105163426.209e8f45@xeon-e3> (raw)
In-Reply-To: <6bd0ce2ca70a5c5264b8783cc168d56766a3f1db.1514993186.git.mschiffer@universe-factory.net>
On Wed, 3 Jan 2018 16:28:52 +0100
Matthias Schiffer <mschiffer@universe-factory.net> wrote:
> Leaving a variable with a generic name such as TARGETS undefined would lead
> to Make picking up its value from the environment. Avoid this by always
> defining TARGETS in the Makefiles.
>
> Signed-off-by: Matthias Schiffer <mschiffer@universe-factory.net>
> ---
>
> I also noticed that many Makefiles refer to a variable LIBS, which is
> neither defined nor documented to be passed from the outside. Is this
> intentional?
>
>
> devlink/Makefile | 4 +++-
> rdma/Makefile | 4 +++-
> tipc/Makefile | 4 +++-
> 3 files changed, 9 insertions(+), 3 deletions(-)
Applied.
Most of the Makefiles are very old.
There maybe other variable issues.
prev parent reply other threads:[~2018-01-06 0:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-03 15:28 [PATCH iproute2] devlink, rdma, tipc: properly define TARGETS without HAVE_MNL Matthias Schiffer
2018-01-06 0:34 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180105163426.209e8f45@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=mschiffer@universe-factory.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).