From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH iproute2] devlink, rdma, tipc: properly define TARGETS without HAVE_MNL Date: Fri, 5 Jan 2018 16:34:26 -0800 Message-ID: <20180105163426.209e8f45@xeon-e3> References: <6bd0ce2ca70a5c5264b8783cc168d56766a3f1db.1514993186.git.mschiffer@universe-factory.net> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: Matthias Schiffer Return-path: Received: from mail-pf0-f196.google.com ([209.85.192.196]:40143 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752988AbeAFAel (ORCPT ); Fri, 5 Jan 2018 19:34:41 -0500 Received: by mail-pf0-f196.google.com with SMTP id v26so2843069pfl.7 for ; Fri, 05 Jan 2018 16:34:41 -0800 (PST) In-Reply-To: <6bd0ce2ca70a5c5264b8783cc168d56766a3f1db.1514993186.git.mschiffer@universe-factory.net> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, 3 Jan 2018 16:28:52 +0100 Matthias Schiffer wrote: > Leaving a variable with a generic name such as TARGETS undefined would lead > to Make picking up its value from the environment. Avoid this by always > defining TARGETS in the Makefiles. > > Signed-off-by: Matthias Schiffer > --- > > I also noticed that many Makefiles refer to a variable LIBS, which is > neither defined nor documented to be passed from the outside. Is this > intentional? > > > devlink/Makefile | 4 +++- > rdma/Makefile | 4 +++- > tipc/Makefile | 4 +++- > 3 files changed, 9 insertions(+), 3 deletions(-) Applied. Most of the Makefiles are very old. There maybe other variable issues.