From: Stephen Hemminger <stephen@networkplumber.org>
To: Serhey Popovych <serhe.popovych@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH iproute2 v2 2/3] link_iptnl: Print tunnel mode
Date: Fri, 5 Jan 2018 16:36:35 -0800 [thread overview]
Message-ID: <20180105163635.07adeaea@xeon-e3> (raw)
In-Reply-To: <1514928479-30313-3-git-send-email-serhe.popovych@gmail.com>
On Tue, 2 Jan 2018 23:27:58 +0200
Serhey Popovych <serhe.popovych@gmail.com> wrote:
> Tunnel mode does not appear in parameters print for iptnl
> supported tunnels like ipip and sit, while printed for
> ip6tnl.
>
> Print tunnel mode as "proto" field name for JSON and
> without any name when printing to cli to follow ip6tnl
> behaviour.
>
> For non JSON output we have:
>
> $ ip -d link show dev sit1
>
> Before:
> -------
> 17: sit1@NONE: <NOARP> mtu 1480 qdisc noop state DOWN ...
> link/sit X.X.X.X brd 0.0.0.0 promiscuity 0
> sit remote any local X.X.X.X ...
> ~~~
>
> After:
> ------
> 17: sit1@NONE: <NOARP> mtu 1480 qdisc noop state DOWN ...
> link/sit X.X.X.X brd 0.0.0.0 promiscuity 0
> sit any remote any local X.X.X.X ...
> ^^^
>
> Signed-off-by: Serhey Popovych <serhe.popovych@gmail.com>
Applied all three to master.
Thanks.
next prev parent reply other threads:[~2018-01-06 0:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-02 21:27 [PATCH iproute2 v2 0/3] iptnl/tunnel: Open JSON section, kill code duplication and print iptnl mode Serhey Popovych
2018-01-02 21:27 ` [PATCH iproute2 v2 1/3] link_iptnl: Kill code duplication Serhey Popovych
2018-01-02 21:27 ` [PATCH iproute2 v2 2/3] link_iptnl: Print tunnel mode Serhey Popovych
2018-01-06 0:36 ` Stephen Hemminger [this message]
2018-01-02 21:27 ` [PATCH iproute2 v2 3/3] link_iptnl: Open "encap" JSON object Serhey Popovych
-- strict thread matches above, loose matches on Subject: below --
2018-01-02 19:54 [PATCH iproute2 2/3] link_iptnl: Print tunnel mode Stephen Hemminger
2018-01-02 21:02 ` [PATCH iproute2 v2 " Serhey Popovych
2018-01-02 21:13 ` Stephen Hemminger
2018-01-02 21:29 ` Serhey Popovych
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180105163635.07adeaea@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=netdev@vger.kernel.org \
--cc=serhe.popovych@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).