From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH iproute2 v2 2/3] link_iptnl: Print tunnel mode Date: Fri, 5 Jan 2018 16:36:35 -0800 Message-ID: <20180105163635.07adeaea@xeon-e3> References: <1514928479-30313-1-git-send-email-serhe.popovych@gmail.com> <1514928479-30313-3-git-send-email-serhe.popovych@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: Serhey Popovych Return-path: Received: from mail-pf0-f174.google.com ([209.85.192.174]:33469 "EHLO mail-pf0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752988AbeAFAgk (ORCPT ); Fri, 5 Jan 2018 19:36:40 -0500 Received: by mail-pf0-f174.google.com with SMTP id y89so2850731pfk.0 for ; Fri, 05 Jan 2018 16:36:40 -0800 (PST) In-Reply-To: <1514928479-30313-3-git-send-email-serhe.popovych@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 2 Jan 2018 23:27:58 +0200 Serhey Popovych wrote: > Tunnel mode does not appear in parameters print for iptnl > supported tunnels like ipip and sit, while printed for > ip6tnl. > > Print tunnel mode as "proto" field name for JSON and > without any name when printing to cli to follow ip6tnl > behaviour. > > For non JSON output we have: > > $ ip -d link show dev sit1 > > Before: > ------- > 17: sit1@NONE: mtu 1480 qdisc noop state DOWN ... > link/sit X.X.X.X brd 0.0.0.0 promiscuity 0 > sit remote any local X.X.X.X ... > ~~~ > > After: > ------ > 17: sit1@NONE: mtu 1480 qdisc noop state DOWN ... > link/sit X.X.X.X brd 0.0.0.0 promiscuity 0 > sit any remote any local X.X.X.X ... > ^^^ > > Signed-off-by: Serhey Popovych Applied all three to master. Thanks.