From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Jakub Kicinski <jakub.kicinski@netronome.com>
Cc: netdev@vger.kernel.org, daniel@iogearbox.net,
davem@davemloft.net, oss-drivers@netronome.com, tehnerd@fb.com
Subject: Re: [PATCH bpf-next 02/16] bpf: array: move checks out of alloc function
Date: Fri, 5 Jan 2018 09:21:02 -0800 [thread overview]
Message-ID: <20180105172100.mk2nhmutvcgplbja@ast-mbp> (raw)
In-Reply-To: <20180105060931.30815-3-jakub.kicinski@netronome.com>
On Thu, Jan 04, 2018 at 10:09:17PM -0800, Jakub Kicinski wrote:
> Use the new callback to perform allocation checks for array maps.
> The fd maps don't need a special allocation callback, they only
> need a special check callback.
>
> Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
> Reviewed-by: Quentin Monnet <quentin.monnet@netronome.com>
LGTM
but I would like to hold on this set until we fix the fallout
from cpu bug. See my patch: https://patchwork.ozlabs.org/patch/855911/
If we merge your set to bpf-next today we'll have very nasty
conflicts between bpf and bpf-next.
I'd like to fix everything necessary for these CVEs in bpf tree first
and get that merged all the way to bpf-next through Linus tree
before proceeding with this refactoring.
Ok?
next prev parent reply other threads:[~2018-01-05 17:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-05 6:09 [PATCH bpf-next 00/16] bpf: support creating maps on networking devices Jakub Kicinski
2018-01-05 6:09 ` [PATCH bpf-next 01/16] bpf: add map_alloc_check callback Jakub Kicinski
2018-01-05 6:09 ` [PATCH bpf-next 02/16] bpf: array: move checks out of alloc function Jakub Kicinski
2018-01-05 17:21 ` Alexei Starovoitov [this message]
2018-01-05 17:40 ` Jakub Kicinski
2018-01-05 6:09 ` [PATCH bpf-next 03/16] bpf: hashtab: move attribute validation before allocation Jakub Kicinski
2018-01-05 6:09 ` [PATCH bpf-next 04/16] bpf: hashtab: move checks out of alloc function Jakub Kicinski
2018-01-05 6:09 ` [PATCH bpf-next 05/16] bpf: add helper for copying attrs to struct bpf_map Jakub Kicinski
2018-01-05 6:09 ` [PATCH bpf-next 06/16] bpf: rename bpf_dev_offload -> bpf_prog_offload Jakub Kicinski
2018-01-05 6:09 ` [PATCH bpf-next 07/16] bpf: offload: factor out netdev checking at allocation time Jakub Kicinski
2018-01-05 6:09 ` [PATCH bpf-next 08/16] bpf: offload: add map offload infrastructure Jakub Kicinski
2018-01-05 6:09 ` [PATCH bpf-next 09/16] nfp: hand over to BPF offload app at coarser granularity Jakub Kicinski
2018-01-05 6:09 ` [PATCH bpf-next 10/16] nfp: bpf: add map data structure Jakub Kicinski
2018-01-05 6:09 ` [PATCH bpf-next 11/16] nfp: bpf: add basic control channel communication Jakub Kicinski
2018-01-05 6:09 ` [PATCH bpf-next 12/16] nfp: bpf: implement helpers for FW map ops Jakub Kicinski
2018-01-05 6:09 ` [PATCH bpf-next 13/16] nfp: bpf: parse function call and map capabilities Jakub Kicinski
2018-01-05 6:09 ` [PATCH bpf-next 14/16] nfp: bpf: add verification and codegen for map lookups Jakub Kicinski
2018-01-05 6:09 ` [PATCH bpf-next 15/16] nfp: bpf: add support for reading map memory Jakub Kicinski
2018-01-05 6:09 ` [PATCH bpf-next 16/16] nfp: bpf: implement bpf map offload Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180105172100.mk2nhmutvcgplbja@ast-mbp \
--to=alexei.starovoitov@gmail.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=jakub.kicinski@netronome.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
--cc=tehnerd@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).