From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To: David Ahern <dsahern@gmail.com>
Cc: Phil Sutter <phil@nwl.cc>, Chris Mi <chrism@mellanox.com>,
netdev@vger.kernel.org, gerlitz.or@gmail.com,
stephen@networkplumber.org
Subject: Re: [patch iproute2 v6 0/3] tc: Add -bs option to batch mode
Date: Fri, 5 Jan 2018 16:45:05 -0200 [thread overview]
Message-ID: <20180105184505.GF725@localhost.localdomain> (raw)
In-Reply-To: <d925a983-f9b9-8360-bc40-ae63530c9d82@gmail.com>
On Fri, Jan 05, 2018 at 10:27:52AM -0700, David Ahern wrote:
> On 1/5/18 10:25 AM, Phil Sutter wrote:
> > I wonder whether specifying the batch size is necessary at all. Couldn't
> > batch mode just collect messages until either EOF or an incompatible
> > command is encountered which then triggers a commit to kernel? This
> > might simplify code quite a bit.
> >
>
> agreed.
Agreed too, especially now that it supports flushing because of other
rules.
Marcelo
next prev parent reply other threads:[~2018-01-05 18:45 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-04 7:34 [patch iproute2 v6 0/3] tc: Add -bs option to batch mode Chris Mi
2018-01-04 7:34 ` [patch iproute2 v6 1/3] lib/libnetlink: Add a function rtnl_talk_msg Chris Mi
2018-01-05 17:50 ` David Ahern
2018-01-09 6:44 ` Chris Mi
2018-01-04 7:34 ` [patch iproute2 v6 2/3] tc: Add -bs option to batch mode Chris Mi
2018-01-05 14:03 ` Marcelo Ricardo Leitner
2018-01-05 18:15 ` David Ahern
2018-01-05 19:14 ` Marcelo Ricardo Leitner
2018-01-09 6:45 ` Chris Mi
2018-01-04 7:34 ` [patch iproute2 v6 3/3] man: Add -bs option to tc manpage Chris Mi
2018-01-05 12:20 ` Marcelo Ricardo Leitner
2018-01-05 17:25 ` [patch iproute2 v6 0/3] tc: Add -bs option to batch mode Phil Sutter
2018-01-05 17:27 ` David Ahern
2018-01-05 18:45 ` Marcelo Ricardo Leitner [this message]
2018-01-08 2:03 ` Chris Mi
2018-01-08 4:00 ` David Ahern
2018-01-08 8:00 ` Chris Mi
2018-01-08 15:40 ` Stephen Hemminger
2018-01-09 1:49 ` Chris Mi
2018-01-08 13:31 ` Phil Sutter
2018-01-09 1:21 ` Chris Mi
2018-01-09 2:35 ` Chris Mi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180105184505.GF725@localhost.localdomain \
--to=marcelo.leitner@gmail.com \
--cc=chrism@mellanox.com \
--cc=dsahern@gmail.com \
--cc=gerlitz.or@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=phil@nwl.cc \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).