From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Subject: Re: [patch iproute2 v6 0/3] tc: Add -bs option to batch mode
Date: Fri, 5 Jan 2018 16:45:05 -0200
Message-ID: <20180105184505.GF725@localhost.localdomain>
References: <20180104073454.11867-1-chrism@mellanox.com>
 <20180105172523.GD14358@orbyte.nwl.cc>
 <d925a983-f9b9-8360-bc40-ae63530c9d82@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Phil Sutter <phil@nwl.cc>, Chris Mi <chrism@mellanox.com>,
        netdev@vger.kernel.org, gerlitz.or@gmail.com,
        stephen@networkplumber.org
To: David Ahern <dsahern@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:43508 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752183AbeAESpI (ORCPT <rfc822;netdev@vger.kernel.org>);
        Fri, 5 Jan 2018 13:45:08 -0500
Content-Disposition: inline
In-Reply-To: <d925a983-f9b9-8360-bc40-ae63530c9d82@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Fri, Jan 05, 2018 at 10:27:52AM -0700, David Ahern wrote:
> On 1/5/18 10:25 AM, Phil Sutter wrote:
> > I wonder whether specifying the batch size is necessary at all. Couldn't
> > batch mode just collect messages until either EOF or an incompatible
> > command is encountered which then triggers a commit to kernel? This
> > might simplify code quite a bit.
> > 
> 
> agreed.

Agreed too, especially now that it supports flushing because of other
rules.

  Marcelo