From mboxrd@z Thu Jan 1 00:00:00 1970 From: Al Viro Subject: Re: [PATCH 03/31] fs: introduce new ->get_poll_head and ->poll_mask methods Date: Sat, 6 Jan 2018 19:12:42 +0000 Message-ID: <20180106191242.GI21978@ZenIV.linux.org.uk> References: <20180104080043.14506-1-hch@lst.de> <20180104080043.14506-4-hch@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Avi Kivity , linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: Christoph Hellwig Return-path: Content-Disposition: inline In-Reply-To: <20180104080043.14506-4-hch@lst.de> Sender: owner-linux-aio@kvack.org List-Id: netdev.vger.kernel.org On Thu, Jan 04, 2018 at 09:00:15AM +0100, Christoph Hellwig wrote: > ->get_poll_head returns the waitqueue that the poll operation is going > to sleep on. Note that this means we can only use a single waitqueue > for the poll, unlike some current drivers that use two waitqueues for > different events. But now that we have keyed wakeups and heavily use > those for poll there aren't that many good reason left to keep the > multiple waitqueues, and if there are any ->poll is still around, the > driver just won't support aio poll. *UGH* Gotta love the optimism, but have you actually done the conversion? I'm particularly suspicious about the locking rules here... -- To unsubscribe, send a message with 'unsubscribe linux-aio' in the body to majordomo@kvack.org. For more info on Linux AIO, see: http://www.kvack.org/aio/ Don't email: aart@kvack.org