From: Stefano Brivio <sbrivio@redhat.com>
To: Antonio Quartulli <a@unstable.cc>
Cc: netdev@vger.kernel.org, Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [iproute2 1/2] ss: fix crash when skipping disabled header field
Date: Sat, 6 Jan 2018 19:53:40 +0100 [thread overview]
Message-ID: <20180106195340.4ffa4bfd@elisabeth> (raw)
In-Reply-To: <20180106183150.10530-1-a@unstable.cc>
On Sun, 7 Jan 2018 02:31:49 +0800
Antonio Quartulli <a@unstable.cc> wrote:
> When the first header field is disabled (i.e. when passing the -t
> option), field_flush() is invoked with the `buffer` global variable
> still zero'd.
> However, in field_flush() we try to access buffer.cur->len
> during variables initialization, thus leading to a SIGSEGV.
Good catch, thanks for fixing this.
> It's interesting to note that this bug appears only when the code
> is compiled with -O0, because the compiler is smart
> enough to immediately jump to the return statement if optimizations
> are enabled and skip the faulty instruction.
I should really have tested all the options with -O0 as well. :( Done
now.
> Cc: Stefano Brivio <sbrivio@redhat.com>
> Cc: Stephen Hemminger <stephen@networkplumber.org>
> Signed-off-by: Antonio Quartulli <a@unstable.cc>
Fixes: 691bd854bf4a ("ss: Buffer raw fields first, then render them as a table")
Reviewed-by: Stefano Brivio <sbrivio@redhat.com>
--
Stefano
next prev parent reply other threads:[~2018-01-06 18:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-06 18:31 [iproute2 1/2] ss: fix crash when skipping disabled header field Antonio Quartulli
2018-01-06 18:31 ` [iproute2 2/2] ss: fix NULL pointer access when parsing unix sockets with oldformat Antonio Quartulli
2018-01-06 19:28 ` Stefano Brivio
2018-01-06 19:51 ` Antonio Quartulli
2018-01-06 18:53 ` Stefano Brivio [this message]
2018-01-09 16:03 ` [iproute2 1/2] ss: fix crash when skipping disabled header field Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180106195340.4ffa4bfd@elisabeth \
--to=sbrivio@redhat.com \
--cc=a@unstable.cc \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).