Re: [PATCH 06/18] x86, barrier: stop speculation for failed access_ok

Ingo Molnar
2018-01-08T18:21:38Z

* Peter Zijlstra <peterz@infradead.org> wrote:

> On Sun, Jan 07, 2018 at 06:24:11PM -0800, Alexei Starovoitov wrote:
> > How about:
> > CONFIG_SPECTRE1_WORKAROUND_INDEX_MASK
> > CONFIG_SPECTRE1_WORKAROUND_LOAD_FENCE
>
> INSTRUCTION_FENCE if anything. LFENCE for Intel (and now also for AMD as
> per 0592b0bce169) is a misnomer, IFENCE would be a better name for it.

Btw., we should probably propagate that naming to most places and only point it
out in comments/documentation that Intel/AMD calls this CPU functionality 'LFENCE'
for historic reasons and that the opcode got stolen for the Spectre fixes.

Thanks,

Ingo