From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Brivio Subject: Re: [PATCH] atm/clip: Use seq_puts() in svc_addr() Date: Sat, 6 Jan 2018 23:25:39 +0100 Message-ID: <20180106232539.5d6bb620@elisabeth> References: <97636808-1d9f-d196-ebce-fbd2505c50e2@users.sourceforge.net> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, Bhumika Goyal , "David S. Miller" , David Windsor , Elena Reshetova , Hans Liljestrand , Johannes Berg , Kees Cook , Roopa Prabhu , LKML , kernel-janitors@vger.kernel.org To: SF Markus Elfring Return-path: In-Reply-To: <97636808-1d9f-d196-ebce-fbd2505c50e2@users.sourceforge.net> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Sat, 6 Jan 2018 22:44:08 +0100 SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 6 Jan 2018 22:34:12 +0100 > > Two strings should be quickly put into a sequence by two function calls. > Thus use the function "seq_puts" instead of "seq_printf". > > This issue was detected by using the Coccinelle software. Can you please explain what the issue really is and what you're trying to do here? One shouldn't need to dig into Coccinelle patterns to find out what you mean, and "strings should be quickly put into a sequence" isn't terribly helpful. -- Stefano