From: David Miller <davem@davemloft.net>
To: sbrivio@redhat.com
Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] tcp: Split BUG_ON() in tcp_tso_should_defer() into two assertions
Date: Mon, 08 Jan 2018 14:12:41 -0500 (EST) [thread overview]
Message-ID: <20180108.141241.1029776389232451671.davem@davemloft.net> (raw)
In-Reply-To: <da6e8a83cd13eebf18aa208a14ddfbeef1fab4a7.1515108700.git.sbrivio@redhat.com>
From: Stefano Brivio <sbrivio@redhat.com>
Date: Fri, 5 Jan 2018 00:38:05 +0100
> The two conditions triggering BUG_ON() are somewhat unrelated:
> the tcp_skb_pcount() check is meant to catch TSO flaws, the
> second one checks sanity of congestion window bookkeeping.
>
> Split them into two separate BUG_ON() assertions on two lines,
> so that we know which one actually triggers, when they do.
>
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Applied.
prev parent reply other threads:[~2018-01-08 19:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-04 23:38 [PATCH net-next] tcp: Split BUG_ON() in tcp_tso_should_defer() into two assertions Stefano Brivio
2018-01-08 19:12 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180108.141241.1029776389232451671.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).