From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next] tcp: Split BUG_ON() in tcp_tso_should_defer() into two assertions Date: Mon, 08 Jan 2018 14:12:41 -0500 (EST) Message-ID: <20180108.141241.1029776389232451671.davem@davemloft.net> References: Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org To: sbrivio@redhat.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:46706 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755097AbeAHTMm (ORCPT ); Mon, 8 Jan 2018 14:12:42 -0500 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: From: Stefano Brivio Date: Fri, 5 Jan 2018 00:38:05 +0100 > The two conditions triggering BUG_ON() are somewhat unrelated: > the tcp_skb_pcount() check is meant to catch TSO flaws, the > second one checks sanity of congestion window bookkeeping. > > Split them into two separate BUG_ON() assertions on two lines, > so that we know which one actually triggers, when they do. > > Signed-off-by: Stefano Brivio Applied.