From: David Miller <davem@davemloft.net>
To: viro@ftp.linux.org.uk
Cc: netdev@vger.kernel.org, peppe.cavallaro@st.com,
Cavallaro@ftp.linux.org.uk, Giuseppe@ftp.linux.org.uk
Subject: Re: Subject: [RFC][PATCH 04/11] stmmac: fix breakage in stmmac_hw_setup()
Date: Mon, 08 Jan 2018 21:02:35 -0500 (EST) [thread overview]
Message-ID: <20180108.210235.1778522203071115101.davem@davemloft.net> (raw)
In-Reply-To: <E1eXXig-0002B1-IA@ZenIV.linux.org.uk>
From: Al Viro <viro@ftp.linux.org.uk>
Date: Fri, 05 Jan 2018 19:31:58 +0000
> Since "drivers: net: stmmac: reworking the PCS code" ->pcs_ctrl_ane()
> had been taking iomem address to access as the first argument; its
> predecessor (->ctrl_ane()) used to take struct mac_device_info instead.
>
> One of the callers had not been converted; as the result, instead of
> reading and modifying a word in card iomem we read and modify a word
> in (or near) the in-core strucct mac_device_info.
>
> Fixes: 70523e639bf8 (drivers: net: stmmac: reworking the PCS code)
> Cc: stable@vger.kernel.org
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Yikes...
Al, can you split the bug fixes like this one into a separate series
for me to pull into my net GIT tree?
Don't include the pure annotation or partial endianness conversion
ones, those should go to net-next.
next prev parent reply other threads:[~2018-01-09 2:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-05 19:31 Subject: [RFC][PATCH 04/11] stmmac: fix breakage in stmmac_hw_setup() Al Viro
2018-01-09 2:02 ` David Miller [this message]
2018-01-25 8:21 ` Niklas Cassel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180108.210235.1778522203071115101.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Cavallaro@ftp.linux.org.uk \
--cc=Giuseppe@ftp.linux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).