From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: Subject: [RFC][PATCH 04/11] stmmac: fix breakage in stmmac_hw_setup() Date: Mon, 08 Jan 2018 21:02:35 -0500 (EST) Message-ID: <20180108.210235.1778522203071115101.davem@davemloft.net> References: Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, peppe.cavallaro@st.com, Cavallaro@ftp.linux.org.uk, Giuseppe@ftp.linux.org.uk To: viro@ftp.linux.org.uk Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:52010 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757590AbeAICCh (ORCPT ); Mon, 8 Jan 2018 21:02:37 -0500 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: From: Al Viro Date: Fri, 05 Jan 2018 19:31:58 +0000 > Since "drivers: net: stmmac: reworking the PCS code" ->pcs_ctrl_ane() > had been taking iomem address to access as the first argument; its > predecessor (->ctrl_ane()) used to take struct mac_device_info instead. > > One of the callers had not been converted; as the result, instead of > reading and modifying a word in card iomem we read and modify a word > in (or near) the in-core strucct mac_device_info. > > Fixes: 70523e639bf8 (drivers: net: stmmac: reworking the PCS code) > Cc: stable@vger.kernel.org > Signed-off-by: Al Viro Yikes... Al, can you split the bug fixes like this one into a separate series for me to pull into my net GIT tree? Don't include the pure annotation or partial endianness conversion ones, those should go to net-next.