From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next v2 1/6] net: Fix netdev_WARN_ONCE macro Date: Mon, 08 Jan 2018 22:05:41 -0500 (EST) Message-ID: <20180108.220541.1359488060683672177.davem@davemloft.net> References: <1515319720-18428-1-git-send-email-galp@mellanox.com> <1515319720-18428-2-git-send-email-galp@mellanox.com> <1515465721.9619.78.camel@perches.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: galp@mellanox.com, netdev@vger.kernel.org, tariqt@mellanox.com, saeedm@mellanox.com To: joe@perches.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:52770 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755178AbeAIDFp (ORCPT ); Mon, 8 Jan 2018 22:05:45 -0500 In-Reply-To: <1515465721.9619.78.camel@perches.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Joe Perches Date: Mon, 08 Jan 2018 18:42:01 -0800 > On Sun, 2018-01-07 at 12:08 +0200, Gal Pressman wrote: >> netdev_WARN_ONCE is broken (whoops..), this fix will remove the >> unnecessary "condition" parameter, add the missing comma and change >> "arg" to "args". >> >> Fixes: 375ef2b1f0d0 ("net: Introduce netdev_*_once functions") >> Signed-off-by: Gal Pressman >> Reviewed-by: Saeed Mahameed >> --- >> include/linux/netdevice.h | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h >> index 352066e..5ff1ef9 100644 >> --- a/include/linux/netdevice.h >> +++ b/include/linux/netdevice.h >> @@ -4407,8 +4407,8 @@ do { \ >> WARN(1, "netdevice: %s%s\n" format, netdev_name(dev), \ >> netdev_reg_state(dev), ##args) >> >> -#define netdev_WARN_ONCE(dev, condition, format, arg...) \ >> - WARN_ONCE(1, "netdevice: %s%s\n" format, netdev_name(dev) \ >> +#define netdev_WARN_ONCE(dev, format, args...) \ >> + WARN_ONCE(1, "netdevice: %s%s\n" format, netdev_name(dev), \ > > You sure you want the newline before the format? Hmmm, Gal please send me a relative fix for this.