From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Kicinski Subject: Re: [RFC -next 2/2] net: sched: red: don't reset the backlog on every stat dump Date: Mon, 8 Jan 2018 10:23:17 -0800 Message-ID: <20180108102317.1a08a7ee@cakuba.netronome.com> References: <20180104201851.6455-1-jakub.kicinski@netronome.com> <20180104201851.6455-3-jakub.kicinski@netronome.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: "john.fastabend@gmail.com" , "jiri@resnulli.us" , "xiyou.wangcong@gmail.com" , Yuval Mintz , "netdev@vger.kernel.org" , "oss-drivers@netronome.com" , "edumazet@google.com" To: Nogah Frankel Return-path: Received: from mail-qt0-f194.google.com ([209.85.216.194]:42483 "EHLO mail-qt0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754560AbeAHSXV (ORCPT ); Mon, 8 Jan 2018 13:23:21 -0500 Received: by mail-qt0-f194.google.com with SMTP id g9so14744121qth.9 for ; Mon, 08 Jan 2018 10:23:20 -0800 (PST) In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Mon, 8 Jan 2018 09:18:08 +0000, Nogah Frankel wrote: > > Unlike for other statistics new_hw_stat < prev_hw_stat can be true. > > Adjust mlxsw. > > There is one problem with this patch, and that is that we can fail in > changing RED that is offloaded. In this case, we delete RED from the driver > but the backlog will still include the hardware backlog. > The solution is to send in the offload-replace command a pointer to the > backlog, so failure in updating the hardware can be follow by backlog update, > if needed. Thanks, will fix.