From: Christoph Hellwig <hch@lst.de>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Christoph Hellwig <hch@lst.de>, Avi Kivity <avi@scylladb.com>,
linux-aio@kvack.org, linux-fsdevel@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 03/31] fs: introduce new ->get_poll_head and ->poll_mask methods
Date: Mon, 8 Jan 2018 11:45:13 +0100 [thread overview]
Message-ID: <20180108104513.GB5797@lst.de> (raw)
In-Reply-To: <20180106191242.GI21978@ZenIV.linux.org.uk>
On Sat, Jan 06, 2018 at 07:12:42PM +0000, Al Viro wrote:
> On Thu, Jan 04, 2018 at 09:00:15AM +0100, Christoph Hellwig wrote:
> > ->get_poll_head returns the waitqueue that the poll operation is going
> > to sleep on. Note that this means we can only use a single waitqueue
> > for the poll, unlike some current drivers that use two waitqueues for
> > different events. But now that we have keyed wakeups and heavily use
> > those for poll there aren't that many good reason left to keep the
> > multiple waitqueues, and if there are any ->poll is still around, the
> > driver just won't support aio poll.
>
> *UGH*
>
> Gotta love the optimism, but have you actually done the conversion?
> I'm particularly suspicious about the locking rules here...
I've done just about everything but random drivers. Which is the ones
where people care about performance and thus aio poll. I suspect that
we will have various odd cruft drivers that will be left alone.
--
To unsubscribe, send a message with 'unsubscribe linux-aio' in
the body to majordomo@kvack.org. For more info on Linux AIO,
see: http://www.kvack.org/aio/
Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>
next prev parent reply other threads:[~2018-01-08 10:45 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-04 8:00 aio poll, io_pgetevents and a new in-kernel poll API Christoph Hellwig
2018-01-04 8:00 ` [PATCH 01/31] fs: update documentation for __poll_t Christoph Hellwig
2018-01-04 8:00 ` [PATCH 02/31] fs: add new vfs_poll and file_can_poll helpers Christoph Hellwig
2018-01-06 19:08 ` Al Viro
2018-01-08 10:44 ` Christoph Hellwig
2018-01-04 8:00 ` [PATCH 03/31] fs: introduce new ->get_poll_head and ->poll_mask methods Christoph Hellwig
2018-01-06 19:12 ` Al Viro
2018-01-08 10:45 ` Christoph Hellwig [this message]
2018-01-10 16:31 ` Al Viro
2018-01-10 17:42 ` Christoph Hellwig
2018-01-04 8:00 ` [PATCH 04/31] net: add support for ->poll_mask in proto_ops Christoph Hellwig
2018-01-06 19:16 ` Al Viro
2018-01-08 10:48 ` Christoph Hellwig
2018-01-09 16:32 ` Christoph Hellwig
2018-01-09 16:41 ` Christoph Hellwig
2018-01-04 8:00 ` [PATCH 05/31] net: remove sock_no_poll Christoph Hellwig
2018-01-04 8:00 ` [PATCH 06/31] net/tcp: convert to ->poll_mask Christoph Hellwig
2018-01-04 8:00 ` [PATCH 07/31] net/unix: " Christoph Hellwig
2018-01-04 8:00 ` [PATCH 08/31] net: convert datagram_poll users tp ->poll_mask Christoph Hellwig
2018-01-04 8:00 ` [PATCH 09/31] net/dccp: convert to ->poll_mask Christoph Hellwig
2018-01-04 8:00 ` [PATCH 10/31] net/atm: " Christoph Hellwig
2018-01-04 8:00 ` [PATCH 11/31] net/vmw_vsock: " Christoph Hellwig
2018-01-04 8:00 ` [PATCH 12/31] net/tipc: " Christoph Hellwig
2018-01-04 8:00 ` [PATCH 13/31] net/sctp: " Christoph Hellwig
2018-01-04 8:00 ` [PATCH 14/31] net/bluetooth: " Christoph Hellwig
2018-01-04 8:00 ` [PATCH 15/31] net/caif: " Christoph Hellwig
2018-01-04 8:00 ` [PATCH 16/31] net/nfc: " Christoph Hellwig
2018-01-04 8:00 ` [PATCH 17/31] net/phonet: " Christoph Hellwig
2018-01-04 8:00 ` [PATCH 18/31] net/iucv: " Christoph Hellwig
2018-01-04 8:00 ` [PATCH 19/31] net/rxrpc: " Christoph Hellwig
2018-01-04 8:00 ` [PATCH 20/31] pipe: " Christoph Hellwig
2018-01-04 8:00 ` [PATCH 21/31] eventfd: switch " Christoph Hellwig
2018-01-04 8:00 ` [PATCH 22/31] timerfd: convert " Christoph Hellwig
2018-01-04 8:00 ` [PATCH 23/31] aio: don't print the page size at boot time Christoph Hellwig
2018-01-09 17:18 ` Jeff Moyer
2018-01-04 8:00 ` [PATCH 24/31] aio: remove an outdated comment in aio_complete Christoph Hellwig
2018-01-09 17:19 ` Jeff Moyer
2018-01-04 8:00 ` [PATCH 25/31] aio: refactor read/write iocb setup Christoph Hellwig
2018-01-04 8:00 ` [PATCH 26/31] aio: sanitize ki_list handling Christoph Hellwig
2018-01-04 8:00 ` [PATCH 27/31] aio: simplify cancellation Christoph Hellwig
2018-01-04 8:00 ` [PATCH 28/31] aio: delete iocbs from the active_reqs list in kiocb_cancel Christoph Hellwig
2018-01-04 8:00 ` [PATCH 29/31] aio: add delayed cancel support Christoph Hellwig
2018-01-04 8:00 ` [PATCH 30/31] aio: implement IOCB_CMD_POLL Christoph Hellwig
2018-01-04 8:00 ` [PATCH 31/31] aio: implement io_pgetevents Christoph Hellwig
2018-01-09 22:16 ` Arnd Bergmann
2018-01-10 8:11 ` Christoph Hellwig
2018-01-10 11:03 ` Arnd Bergmann
2018-01-10 14:59 ` Christoph Hellwig
2018-01-10 15:48 ` Arnd Bergmann
2018-01-10 15:49 ` Christoph Hellwig
2018-01-10 15:56 ` Christoph Hellwig
2018-01-04 9:09 ` aio poll, io_pgetevents and a new in-kernel poll API Christoph Hellwig
2018-01-09 12:28 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180108104513.GB5797@lst.de \
--to=hch@lst.de \
--cc=avi@scylladb.com \
--cc=linux-aio@kvack.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).